From: Prarit Bhargava <prarit@redhat.com>
To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
mingo@redhat.com, randy.dunlap@oracle.com
Cc: Prarit Bhargava <prarit@redhat.com>
Subject: [PATCH]: Fix overloaded use of apic= on bootline
Date: Mon, 21 May 2007 10:08:47 -0400 [thread overview]
Message-ID: <20070521140847.11958.47504.sendpatchset@prarit.boston.redhat.com> (raw)
Andrew, I've submitted this a couple of times and it's had a review by Randy.
Any chance we can get this in?
Thanks,
P.
The use of "apic=" on the boot line is overloaded. It is used once to
override the type of genapic, and then later on it is used to determine a debug
level. Because of this a bogus error message is sent to the console when using
the debug option:
Unknown genapic `apic=debug' specified.
This patch changes the genapic situation to use "genapic=".
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index 09220a1..f156b59 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -636,6 +636,9 @@ and is between 256 and 4096 characters. It is defined in the file
gamma= [HW,DRM]
+ genapic= [APIC,i386] Select a specific genapic type to be used.
+ Format: <name>
+
gdth= [HW,SCSI]
See header of drivers/scsi/gdth.c.
diff --git a/arch/i386/mach-generic/probe.c b/arch/i386/mach-generic/probe.c
index 74f3da6..ce78b15 100644
--- a/arch/i386/mach-generic/probe.c
+++ b/arch/i386/mach-generic/probe.c
@@ -49,7 +49,7 @@ static int __init parse_apic(char *arg)
/* Parsed again by __setup for debug/verbose */
return 0;
}
-early_param("apic", parse_apic);
+early_param("genapic", parse_apic);
void __init generic_bigsmp_probe(void)
{
reply other threads:[~2007-05-21 14:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070521140847.11958.47504.sendpatchset@prarit.boston.redhat.com \
--to=prarit@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox