From: Al Viro <viro@ftp.linux.org.uk>
To: akpm@linux-foundation.org
Cc: mm-commits@vger.kernel.org, kenchen@google.com,
viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: + loop-preallocate-eight-loop-devices.patch added to -mm tree
Date: Tue, 22 May 2007 01:18:51 +0100 [thread overview]
Message-ID: <20070522001851.GE4095@ftp.linux.org.uk> (raw)
In-Reply-To: <200705212200.l4LM0tYK021050@shell0.pdx.osdl.net>
On Mon, May 21, 2007 at 03:00:55PM -0700, akpm@linux-foundation.org wrote:
> + if (register_blkdev(LOOP_MAJOR, "loop"))
> + return -EIO;
> + blk_register_region(MKDEV(LOOP_MAJOR, 0), range,
> + THIS_MODULE, loop_probe, NULL, NULL);
> +
> + for (i = 0; i < nr; i++) {
> + if (!loop_init_one(i))
> + goto err;
> + }
> +
> + printk(KERN_INFO "loop: module loaded\n");
> + return 0;
> +err:
> + loop_exit();
This isn't good. You *can't* fail once a single disk has been registered.
Anyone could've opened it by now.
IOW, you need to
* register region *after* you are past the point of no return
* either not fail on failing loop_init_one() here, or separate
allocations and actual add_disk().
next parent reply other threads:[~2007-05-22 0:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200705212200.l4LM0tYK021050@shell0.pdx.osdl.net>
2007-05-22 0:18 ` Al Viro [this message]
2007-05-22 1:30 ` + loop-preallocate-eight-loop-devices.patch added to -mm tree Ken Chen
2007-05-22 1:48 ` Al Viro
2007-05-22 2:14 ` Ken Chen
2007-05-22 2:40 ` Ken Chen
2007-05-22 4:18 ` Al Viro
2007-05-31 16:05 ` walt
2007-05-31 16:51 ` Ken Chen
2007-05-31 18:10 ` Andrew Morton
2007-05-31 18:23 ` Ken Chen
2007-05-31 18:34 ` Andrew Morton
2007-06-01 16:29 ` Ken Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070522001851.GE4095@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=kenchen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox