From: Ingo Molnar <mingo@elte.hu>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Torvalds <torvalds@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, David Miller <davem@davemloft.net>,
Stable Team <stable@kernel.org>,
Anant Nitya <kernel@prachanda.info>
Subject: Re: [PATCH] Prevent going idle with softirq pending
Date: Tue, 22 May 2007 07:04:10 +0200 [thread overview]
Message-ID: <20070522050410.GA9295@elte.hu> (raw)
In-Reply-To: <1179783264.12708.70.camel@chaos>
* Thomas Gleixner <tglx@linutronix.de> wrote:
> The NOHZ patch contains a check for softirqs pending when a CPU goes
> idle. The BUG is unrelated to NOHZ, it just was made visible by the
> NOHZ patch. The BUG showed up mainly on P4 / hyperthreading enabled
> machines which lead the investigations into the wrong direction in the
> first place. The real cause is in cond_resched_softirq():
>
> cond_resched_softirq() is enabling softirqs without invoking the
> softirq daemon when softirqs are pending. This leads to the warning
> message in the NOHZ idle code:
good find!
> raw_local_irq_disable();
> - _local_bh_enable();
> + local_bh_enable();
> raw_local_irq_enable();
hm, i think this should be done without having irqs disabled?
Ingo
next prev parent reply other threads:[~2007-05-22 5:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 21:34 [PATCH] Prevent going idle with softirq pending Thomas Gleixner
2007-05-22 5:04 ` Ingo Molnar [this message]
2007-05-22 6:32 ` Andrew Morton
2007-05-22 6:38 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070522050410.GA9295@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=kernel@prachanda.info \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox