linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Anant Nitya <kernel@prachanda.info>
Cc: linux-kernel@vger.kernel.org, Patrick McHardy <kaber@trash.net>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: bad networking related lag in v2.6.22-rc2
Date: Tue, 22 May 2007 08:22:33 +0200	[thread overview]
Message-ID: <20070522062233.GA20002@elte.hu> (raw)
In-Reply-To: <200705221147.56571.kernel@prachanda.hub>


* Anant Nitya <kernel@prachanda.info> wrote:

> > I think I already found the bug, please try if this patch helps.
> 
> Sorry, but this patch is not helping here. I recompiled the kernel 
> with this patch but same load pattern still make system to crawl.
> 
> Here is the link for script I use to shape traffic.
> 
> http://cybertek.info/taitai/adslbwopt.sh

could you also apply the fix for the softirq problem below, to make sure 
it does not interact?

	Ingo

Index: linux/kernel/sched.c
===================================================================
--- linux.orig/kernel/sched.c
+++ linux/kernel/sched.c
@@ -4212,9 +4212,7 @@ int __sched cond_resched_softirq(void)
 	BUG_ON(!in_softirq());
 
 	if (need_resched() && system_state == SYSTEM_RUNNING) {
-		raw_local_irq_disable();
-		_local_bh_enable();
-		raw_local_irq_enable();
+		local_bh_enable();
 		__cond_resched();
 		local_bh_disable();
 		return 1;

  reply	other threads:[~2007-05-22  6:23 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-17 17:45 [patch] CFS scheduler, -v13 Ingo Molnar
2007-05-17 21:47 ` Anant Nitya
2007-05-18 10:26   ` Ingo Molnar
2007-05-18 16:13     ` Anant Nitya
2007-05-19 21:16     ` Anant Nitya
2007-05-20  6:38       ` Ingo Molnar
2007-05-21  7:58       ` bad networking related lag in v2.6.22-rc2 Ingo Molnar
2007-05-21  8:03         ` Ingo Molnar
2007-05-21  8:05           ` Ingo Molnar
2007-05-21  8:12           ` Ingo Molnar
2007-05-21  8:29             ` David Miller
2007-05-21 10:09               ` Ingo Molnar
2007-05-21 10:14             ` Anant Nitya
2007-05-21 10:20               ` Ingo Molnar
2007-05-22  6:20                 ` Anant Nitya
2007-05-21 19:40             ` Anant Nitya
2007-05-21 20:46               ` Ingo Molnar
2007-05-21 21:02                 ` Patrick McHardy
2007-05-21 21:30                   ` Patrick McHardy
2007-05-22  6:17                     ` Anant Nitya
2007-05-22  6:22                       ` Ingo Molnar [this message]
2007-05-23  5:40                         ` Anant Nitya
2007-05-23  6:30                           ` Ingo Molnar
2007-05-23 10:56                             ` Patrick McHardy
2007-05-23 11:05                               ` Ingo Molnar
2007-05-23 11:25                               ` Herbert Xu
2007-05-23 11:33                                 ` Patrick McHardy
2007-05-23 15:00                                   ` Linus Torvalds
2007-05-23 17:16                                     ` Patrick McHardy
2007-05-23 11:40                                 ` Ingo Molnar
2007-05-23 21:30                                   ` David Miller
2007-05-24  5:41                                     ` Patrick McHardy
2007-05-24  6:40                                       ` David Miller
2007-05-24  7:12                                     ` Anant Nitya
2007-05-22  6:23                       ` Ingo Molnar
2007-05-22  6:24                         ` Ingo Molnar
2007-05-22  9:17                       ` Patrick McHardy
2007-05-22 12:47                         ` Anant Nitya
2007-05-21  8:25         ` David Miller
2007-05-21  8:28           ` Ingo Molnar
2007-05-21  8:30             ` David Miller
2007-05-21 15:57       ` [patch] CFS scheduler, -v13 Linus Torvalds
2007-05-22 22:06   ` Bill Davidsen
2007-05-23  5:45     ` Anant Nitya
2007-05-18 15:20 ` Michael Lothian
2007-05-18 15:56   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070522062233.GA20002@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=kernel@prachanda.info \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).