Re: [PATCH] UDF: possible usage of uninitialized variables

[Andrew Morton <akpm@linux-foundation.org>]

On Tue, 22 May 2007 21:52:23 +0400
Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> A few variables could be used without being explicitly initialized.
> Fixed.

Are you sure?  I'm expecting that this is a gcc mistake.

> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> 
> 
>  balloc.c |    6 +++++-
>  super.c  |    5 ++++-
>  2 files changed, 9 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/balloc.c b/balloc.c
> index 4cec910..be37393 100644
> --- a/balloc.c
> +++ b/balloc.c

Please always use `patch -p1' form from the top-level directory.  This should
have been

--- a/fs/udf/balloc.c
+++ b/fs/udf/balloc.c

> @@ -744,7 +744,11 @@ static int udf_table_new_block(struct super_block * sb,
>  	uint32_t spread = 0xFFFFFFFF, nspread = 0xFFFFFFFF;
>  	uint32_t newblock = 0, adsize;
>  	uint32_t elen, goal_elen = 0;
> -	kernel_lb_addr eloc, goal_eloc;
> +	kernel_lb_addr eloc;
> +	kernel_lb_addr goal_eloc = {
> +		.logicalBlockNum = 0,
> +		.partitionReferenceNum = 0,
> +	};

	kernel_lb_addr goal_eloc = { };

is equivalent and sufficient.