Re: [Xen-devel] [patch 21/33] xen: Xen SMP guest support

Jeremy Fitzhardinge
2007-06-06T08:33:36Z

Jan Beulich wrote:
>> --- a/arch/i386/xen/time.c
>> +++ b/arch/i386/xen/time.c
>> @@ -105,17 +105,15 @@ static void get_runstate_snapshot(struct
>> preempt_enable();
>> }
>>
>> -static void setup_runstate_info(void)
>> +static void setup_runstate_info(int cpu)
>> {
>> struct vcpu_register_runstate_memory_area area;
>>
>> - area.addr.v = &__get_cpu_var(runstate);
>> + area.addr.v = &per_cpu(runstate, cpu);
>>
>> if (HYPERVISOR_vcpu_op(VCPUOP_register_runstate_memory_area,
>> smp_processor_id(), &area))
>>
>
> Shouldn't this be 'cpu' rather than 'smp_processor_id()'?
>

Yes. I'd noticed that, thought it got fixed later in the series, and
looks like I ultimately got confused. Not sure when this crept in; it
has been correct in the past.

J