public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Chris Wright <chrisw@sous-sol.org>
Subject: Re: [stable] Wanted: Allow adding new device IDs during the -stable cycle
Date: Tue, 22 May 2007 11:47:33 -0700	[thread overview]
Message-ID: <20070522184733.GA9357@kroah.com> (raw)
In-Reply-To: <46533314.10206@redhat.com>

On Tue, May 22, 2007 at 02:14:44PM -0400, Chuck Ebbert wrote:
> I'd like to propose we allow adding new device IDs as part
> of the -stable process, but only under certain conditions:

Who would be the primary benifactor of this?

The very large majority of users out there use a distro kernel, and they
provide the ids whenever possible as patches to their kernels, _or_ as a
config option at startup that adds the ids to the drivers through sysfs.

> 1) Each device (or group of devices) gets added as a separate
>    patch, i.e. we don't just diff the device tables. This way
>    each original patch that added the device(s) upstream will
>    be become a single patch for -stable.
> 
> 2) Devices that require new features/capabilities in their
>    driver won't be added.

What's wrong with the current sysfs way of adding new device ids without
touching the kernel?  Devices described above was the very reason we
added that functionality, so users would not have to constantly update
their kernel.  The distros provide userspace tools that enable these ids
to be added and at boot time, everything "just works" properly.

So, because of that, I don't really see a need to be adding new device
ids to the -stable tree.

> Candidate patches would be something like these, which together
> add support for the ATI SB700 ATA controller:
> 
> 1)
> http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=823777181b4c0200923dcb026efa5b37f55c0ecf
> 
> Adds ATI sb700 quirk, using exactly the same one as sb600.

That's a quirk addition, not a new device id following the above
mentioned rules you set out :)

thanks,

greg k-h

  reply	other threads:[~2007-05-22 18:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-22 18:14 [stable] Wanted: Allow adding new device IDs during the -stable cycle Chuck Ebbert
2007-05-22 18:47 ` Greg KH [this message]
2007-05-22 18:53   ` Dave Jones
2007-05-22 19:36     ` Greg KH
2007-05-22 19:04   ` Jeff Garzik
2007-05-22 19:35     ` Greg KH
2007-05-22 19:51       ` Dave Jones
2007-05-22 22:17         ` Greg KH
2007-05-22 22:56           ` Dave Jones
2007-05-23  0:06             ` Greg KH
2007-05-24  1:20           ` David Hollis
2007-05-24 20:44             ` Jeff Garzik
2007-05-22 20:24       ` Jeff Garzik
2007-05-22 22:15         ` Greg KH
2007-05-22 22:00       ` Chris Wright
2007-05-22 22:19         ` Greg KH
2007-05-22 22:47         ` Jeff Garzik
2007-05-23  0:25           ` Chris Wright
2007-05-24 10:04     ` Pavel Machek
2007-05-24 10:06       ` Jeff Garzik
2007-05-25  6:46         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070522184733.GA9357@kroah.com \
    --to=greg@kroah.com \
    --cc=cebbert@redhat.com \
    --cc=chrisw@sous-sol.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox