Re: [stable] Wanted: Allow adding new device IDs during the -stable cycle

[Dave Jones <davej@redhat.com>]

On Tue, May 22, 2007 at 11:47:33AM -0700, Greg Kroah-Hartman wrote:
 > On Tue, May 22, 2007 at 02:14:44PM -0400, Chuck Ebbert wrote:
 > > I'd like to propose we allow adding new device IDs as part
 > > of the -stable process, but only under certain conditions:
 > 
 > Who would be the primary benifactor of this?
 > 
 > The very large majority of users out there use a distro kernel, and they
 > provide the ids whenever possible as patches to their kernels, _or_ as a
 > config option at startup that adds the ids to the drivers through sysfs.

It does mean however that there's lots of duplicated work between
distros as everyone adds these patches anyway.

 > What's wrong with the current sysfs way of adding new device ids without
 > touching the kernel?

sure, that works in some cases, but for others (quirks etc) it obviously doesn't.

 > > http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=823777181b4c0200923dcb026efa5b37f55c0ecf
 > > 
 > > Adds ATI sb700 quirk, using exactly the same one as sb600.
 > 
 > That's a quirk addition, not a new device id following the above
 > mentioned rules you set out :)

Right, but adding the quirk alone would be pointless with the ID.
This is a case where 'use sysfs' doesn't work.

	Dave

-- 
http://www.codemonkey.org.uk