From: Andrew Morton <akpm@linux-foundation.org>
To: "young dave" <hidave.darkstar@gmail.com>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Steven French" <sfrench@us.ibm.com>
Subject: Re: 2.6.22-rc1-mm1 cifs_mount oops
Date: Tue, 22 May 2007 20:21:33 -0700 [thread overview]
Message-ID: <20070522202133.552d1a94.akpm@linux-foundation.org> (raw)
In-Reply-To: <a8e1da0705221959i7b01deb7vdd641ef0ed31e63e@mail.gmail.com>
On Wed, 23 May 2007 02:59:07 +0000 "young dave" <hidave.darkstar@gmail.com> wrote:
> Hi,
> maybe we can add if sentence before kthread_stop.
>
> diff -ur linux/fs/cifs/connect.c linux.new/fs/cifs/connect.c
> --- linux/fs/cifs/connect.c 2007-05-23 10:59:13.000000000 +0000
> +++ linux.new/fs/cifs/connect.c 2007-05-23 10:58:39.000000000 +0000
> @@ -2070,7 +2070,8 @@
> spin_unlock(&GlobalMid_Lock);
> if (srvTcp->tsk) {
> send_sig(SIGKILL,srvTcp->tsk,1);
> - kthread_stop(srvTcp->tsk);
> + if(srvTcp->tsk)
> + kthread_stop(srvTcp->tsk);
> }
> }
Yeah, that's racy: once we've sent the signal, the kernel thread can write
NULL to srvTcp->tsk at any time.
next prev parent reply other threads:[~2007-05-23 3:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 0:50 2.6.22-rc1-mm1 cifs_mount oops young dave
2007-05-23 2:22 ` Andrew Morton
2007-05-23 2:59 ` young dave
2007-05-23 3:21 ` Andrew Morton [this message]
2007-05-23 7:16 ` young dave
2007-05-23 8:37 ` young dave
2007-05-23 13:28 ` Steven French
2007-05-23 16:10 ` Andrew Morton
2007-05-23 22:14 ` Steven French
2007-05-24 1:05 ` young dave
2007-05-24 2:38 ` Steven French
2007-05-23 13:56 ` Steven French
-- strict thread matches above, loose matches on Subject: below --
2007-05-23 14:59 Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070522202133.552d1a94.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox