public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: suresh.b.siddha@intel.com, clameter@sgi.com, kiran@scalex86.org,
	rmk@arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Define new percpu interface for shared data -- version 3
Date: Wed, 23 May 2007 10:49:46 -0700	[thread overview]
Message-ID: <20070523104946.f279241c.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070522182003.GA28106@linux-os.sc.intel.com>

On Tue, 22 May 2007 11:20:03 -0700 Fenghua Yu <fenghua.yu@intel.com> wrote:

> per cpu data section contains two types of data. One set which is exclusively
> accessed by the local cpu and the other set which is  per cpu, but also shared
> by remote cpus. In the current kernel, these two sets are not clearely
> separated out. This can potentially cause the same data cacheline shared
> between the two sets of data, which will result in unnecessary bouncing of the
> cacheline between cpus.
> 
> One way to fix the problem is to cacheline align the remotely accessed per cpu
> data, both at the beginning and at the end. Because of the padding at both ends,
> this will likely cause some memory wastage and also the interface to achieve
> this is not clean.
> 
> This patch:
> 
> Moves the remotely accessed per cpu data (which is currently marked
> as ____cacheline_aligned_in_smp) into a different section, where all the data
> elements are cacheline aligned. And as such, this differentiates the local
> only data and remotely accessed data cleanly.

OK, but could we please have a concise description of the impact
of these changes on kernel memory footprint?  Increase or decrease?
And by approximately how much?

Thanks.

  reply	other threads:[~2007-05-23 17:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-22 12:47 is TIF_NOTIFY_RESUME used? Stephane Eranian
2007-05-22 16:02 ` Andrew Morton
2007-05-22 16:07   ` Stephane Eranian
2007-05-22 16:15     ` Andrew Morton
2007-05-22 22:51       ` Stephane Eranian
2007-05-22 23:02         ` Andrew Morton
2007-05-23  9:57           ` [PATCH] remove unused TIF_NOTIFY_RESUME flag Stephane Eranian
2007-05-22 18:20   ` [PATCH 1/2] Define new percpu interface for shared data -- version 3 Fenghua Yu
2007-05-23 17:49     ` Andrew Morton [this message]
2007-05-23 18:26       ` Yu, Fenghua
2007-05-23 18:57         ` Ravikiran G Thirumalai
2007-05-23 19:09           ` Yu, Fenghua
2007-05-23 19:20             ` Ravikiran G Thirumalai
2007-05-23 19:31               ` Andrew Morton
2007-05-23 21:13                 ` Yu, Fenghua
2007-05-25  9:43                   ` Russell King
2007-05-25 15:24                     ` Yu, Fenghua
2007-05-24  9:03           ` Martin Schwidefsky
2007-05-24 10:16             ` Ravikiran G Thirumalai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070523104946.f279241c.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=fenghua.yu@intel.com \
    --cc=kiran@scalex86.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=suresh.b.siddha@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox