From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Cliff Wickman <cpw@sgi.com>,
linux-kernel@vger.kernel.org, Paul Jackson <pj@sgi.com>,
Christoph Lameter <christoph@lameter.com>,
Paul Menage <menage@google.com>,
Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: [PATCH 1/1] hotplug cpu: migrate a task within its cpuset
Date: Thu, 24 May 2007 09:56:01 +0200 [thread overview]
Message-ID: <20070524075601.GB21138@elte.hu> (raw)
In-Reply-To: <20070523104315.6b9089dc.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> > When a cpu is disabled, move_task_off_dead_cpu() is called for tasks
> > that have been running on that cpu.
>
> So I still have these three patches in the pending queue but I was
> rather hoping that the scheduler, sched-domains and cpuset people
> could take a look at them, please.
>
> They hit sched.c and cpuset.c mainly, and they might trash Ingo's CFS
> patch (I haven't checked).
The patch looks good to me. It applies cleanly ontop of CFS and it
builds and boots fine with and without CONFIG_CPU_HOTPLUG (although i
havent tried to explicitly stress the codepath in question). We are a
bit paranoid in this codepath but it's not performance-critical
normally.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2007-05-24 7:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 20:08 [PATCH 1/1] hotplug cpu: migrate a task within its cpuset Cliff Wickman
2007-05-23 17:43 ` Andrew Morton
2007-05-24 7:56 ` Ingo Molnar [this message]
2007-05-29 19:32 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2007-08-24 22:18 Cliff Wickman
2007-08-24 22:54 ` Andrew Morton
2007-08-25 9:47 ` Oleg Nesterov
2007-08-26 0:16 ` Gautham R Shenoy
2007-08-26 0:47 ` Rusty Russell
2007-08-26 8:09 ` Andrew Morton
2007-08-27 7:01 ` Rusty Russell
2007-08-25 9:58 ` Oleg Nesterov
2007-08-25 11:18 ` Oleg Nesterov
2007-05-23 21:29 Oleg Nesterov
2007-05-23 22:56 ` Cliff Wickman
2007-05-23 23:32 ` Oleg Nesterov
2007-03-09 19:39 Cliff Wickman
2007-03-09 23:58 ` Nathan Lynch
2007-03-15 0:36 ` Robin Holt
2007-03-15 7:32 ` Nathan Lynch
2007-03-10 9:19 ` Ingo Molnar
2007-03-10 15:51 ` Nathan Lynch
2007-03-10 17:08 ` Ingo Molnar
2007-03-07 14:24 Cliff Wickman
2007-03-07 18:25 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070524075601.GB21138@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=christoph@lameter.com \
--cc=cpw@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=nickpiggin@yahoo.com.au \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox