public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>, Jan Kara <jack@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Hellwig <hch@infradead.org>,
	Ben Fennema <bfennema@falcon.csc.calpoly.edu>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]: UDF code style conversion to kernel style
Date: Thu, 24 May 2007 23:08:26 +0400	[thread overview]
Message-ID: <20070524190826.GC20500@cvg> (raw)
In-Reply-To: <84144f020705241147j5e2fa91bg229db86a63a9efb5@mail.gmail.com>

[Pekka Enberg - Thu, May 24, 2007 at 09:47:42PM +0300]
| Hi Cyrill,
| 
| On 5/23/07, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
| >@@ -2103,7 +1944,7 @@ long udf_block_map(struct inode *inode, sector_t 
| >block)
| > 	kernel_lb_addr eloc;
| > 	uint32_t elen;
| > 	sector_t offset;
| >-	struct extent_position epos = { NULL, 0, { 0, 0}};
| >+	struct extent_position epos = {};
| 
| Bits like these in the middle of indentation fixes makes me feel
| uneasy. Could we simply ask Andrew to run Lindent on the UDF sources
| at some convinient point and push those to Linus like we did with
| mm/slab.c if I recall correctly? Its safer to do cleanups like these
| after that.
| 

And Pekka the patch I sent will be remaked anyway after some fixes. So
if you don't like the conversion you pointed - just let me know and
I'll not do that ;)

		Cyrill


  parent reply	other threads:[~2007-05-24 19:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-23 18:44 [PATCH]: UDF code style conversion to kernel style Cyrill Gorcunov
     [not found] ` <20070524083714.GA27047@duck.suse.cz>
2007-05-24 14:34   ` Cyrill Gorcunov
2007-05-24 18:47 ` Pekka Enberg
2007-05-24 18:57   ` Randy Dunlap
2007-05-24 19:09     ` Pekka Enberg
2007-05-24 19:06   ` Cyrill Gorcunov
2007-05-24 19:28     ` Andrew Morton
2007-05-24 19:08   ` Cyrill Gorcunov [this message]
2007-05-24 19:11     ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070524190826.GC20500@cvg \
    --to=gorcunov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bfennema@falcon.csc.calpoly.edu \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox