public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	Jay Cliburn <jacliburn@bellsouth.net>,
	Grzegorz Krzystek <ninex@NineX.eu.org>, Andi Kleen <ak@suse.de>,
	ninex@o2.pl, <linux-kernel@vger.kernel.org>,
	<linux-pci@atrey.karlin.mff.cuni.cz>,
	Michael Ellerman <michael@ellerman.id.au>,
	David Miller <davem@davemloft.net>,
	Tony Luck <tony.luck@intel.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.
Date: Thu, 24 May 2007 21:31:57 -0700	[thread overview]
Message-ID: <20070524213157.1d39458f.akpm@linux-foundation.org> (raw)
In-Reply-To: <m1veehcz7m.fsf_-_@ebiederm.dsl.xmission.com>

On Thu, 24 May 2007 22:19:09 -0600 ebiederm@xmission.com (Eric W. Biederman) wrote:

> Currently we blacklist known bad msi configurations which means we
> keep getting MSI enabled on chipsets that either do not support MSI,
> or MSI is implemented improperly.  Since the normal IRQ routing
> mechanism seems to works even when MSI does not, this is a bad default
> and causes non-functioning systems for no good reason.
> 
> So this patch inverts the sense of the MSI bus flag to only enable
> MSI on known good systems.  I am seeding that list with the set of
> chipsets with an enabled hypertransport MSI mapping capability.  Which
> is as close as I can come to an generic MSI enable.  So for actually
> using MSI this patch is a regression, but for just having MSI enabled
> in the kernel by default things should just work with this patch
> applied.
> 
> People can still enable MSI on a per bus level for testing by writing
> to sysfs so discovering chipsets that actually work (assuming we are
> using modular drivers) should be pretty straight forward.

Yup.

Do we have a feel for how much performace we're losing on those 
systems which _could_ do MSI, but which will end up defaulting
to not using it?

  parent reply	other threads:[~2007-05-25  4:33 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200705122146.l4CLkH6q012322@fire-2.osdl.org>
     [not found] ` <m1mz09p1t7.fsf@ebiederm.dsl.xmission.com>
     [not found]   ` <20070513014622.c5702928.akpm@linux-foundation.org>
     [not found]     ` <46470209.9000502@bellsouth.net>
     [not found]       ` <46470515.50000@NineX.eu.org>
     [not found]         ` <464707F7.6080600@bellsouth.net>
     [not found]           ` <m1irawpwy2.fsf@ebiederm.dsl.xmission.com>
     [not found]             ` <20070513204407.7ba35010@osprey.hogchain.net>
     [not found]               ` <4647FA38.3090108@NineX.eu.org>
     [not found]                 ` <46480EA5.40400@NineX.eu.org>
     [not found]                   ` <20070514053406.478bf93f@osprey.hogchain.net>
     [not found]                     ` <m1d513oddj.fsf@ebiederm.dsl.xmission.com>
     [not found]                       ` <20070514093829.377e04bc@osprey.hogchain.net>
     [not found]                         ` <m18xbrnyxi.fsf@ebiederm.dsl.xmission.com>
     [not found]                           ` <20070514160005.627435e3@osprey.hogchain.net>
     [not found]                             ` <m1odkmmft4.fsf@ebiederm.dsl.xmission.com>
     [not found]                               ` <20070515212200.517fcba2@osprey.hogchain.net>
     [not found]                                 ` <m14pmcmz8r.fsf@ebiederm.dsl.xmission.com>
     [not found]                                   ` <20070516185225.3f3ac082@osprey.hogchain.net>
     [not found]                                     ` <m1sl9wl28m.fsf@ebiederm.dsl.xmission.com>
     [not found]                                       ` <20070522204103.134bf5a2@osprey.hogchain.net>
2007-05-25  4:19                                         ` [PATCH 1/2] msi: Invert the sense of the MSI enables Eric W. Biederman
2007-05-25  4:26                                           ` [PATCH 2/2] msi: Add support for the Intel chipsets that support MSI Eric W. Biederman
2007-05-25  5:38                                             ` Andi Kleen
2007-05-25  6:10                                               ` Eric W. Biederman
2007-05-25 14:42                                                 ` Chuck Ebbert
2007-05-25 16:52                                                   ` Eric W. Biederman
2007-05-25  4:31                                           ` Andrew Morton [this message]
2007-05-25  5:20                                             ` [PATCH 1/2] msi: Invert the sense of the MSI enables Eric W. Biederman
2007-05-25  5:44                                             ` Grant Grundler
2007-05-25  5:51                                             ` Andi Kleen
2007-05-25 20:16                                               ` Jonathan Lundell
2007-05-26  6:52                                                 ` Grant Grundler
2007-05-25  5:14                                           ` Michael Ellerman
2007-05-25  5:59                                             ` Eric W. Biederman
2007-05-25  6:40                                             ` David Miller
2007-05-25  5:20                                           ` Greg KH
2007-05-25  5:57                                             ` Eric W. Biederman
2007-05-25 15:17                                             ` Eric W. Biederman
2007-05-25 15:28                                               ` Chuck Ebbert
2007-05-25 15:40                                               ` Roland Dreier
2007-05-25 15:42                                                 ` Roland Dreier
2007-05-25 16:10                                                   ` Eric W. Biederman
2007-05-25 20:09                                                     ` David Schwartz
2007-05-25 20:25                                                     ` Roland Dreier
2007-05-25 20:35                                               ` Greg KH
2007-05-25 21:06                                                 ` Eric W. Biederman
2007-05-25 21:17                                                   ` Roland Dreier
2007-05-25 21:31                                                   ` Greg KH
2007-05-26  6:43                                                 ` Grant Grundler
2007-05-25 21:47                                           ` Brice Goglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070524213157.1d39458f.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ak@suse.de \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@suse.de \
    --cc=jacliburn@bellsouth.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=michael@ellerman.id.au \
    --cc=ninex@NineX.eu.org \
    --cc=ninex@o2.pl \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox