Re: [PATCH] Display Intel Dynamic Acceleration feature in /proc/cpuinfo

Venki Pallipadi
2007-05-24T22:11:42Z

On Thu, May 24, 2007 at 03:02:23PM -0700, Andrew Morton wrote:
> On Wed, 23 May 2007 15:46:37 -0700
> Venki Pallipadi <venkatesh.pallipadi@intel.com> wrote:
>
> > Display Intel Dynamic Acceleration feature in /proc/cpuinfo. This feature
> > will be enabled automatically by current acpi-cpufreq driver and cpufreq.
> >
> > Refer to Intel Software Developer's Manual for more details about the feature.
> >
> > Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
> >
> > Index: linux-2.6.22-rc-mm/arch/i386/kernel/cpu/proc.c
> > ===================================================================
> > --- linux-2.6.22-rc-mm.orig/arch/i386/kernel/cpu/proc.c
> > +++ linux-2.6.22-rc-mm/arch/i386/kernel/cpu/proc.c
> > @@ -41,7 +41,7 @@ static int show_cpuinfo(struct seq_file
> > "cxmmx", "k6_mtrr", "cyrix_arr", "centaur_mcr",
> > NULL, NULL, NULL, NULL,
> > "constant_tsc", "up", NULL, NULL, NULL, NULL, NULL, NULL,
> > - NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> > + "ida", NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> > NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> >
> > /* Intel-defined (#2) */
> > Index: linux-2.6.22-rc-mm/arch/x86_64/kernel/setup.c
> > ===================================================================
> > --- linux-2.6.22-rc-mm.orig/arch/x86_64/kernel/setup.c
> > +++ linux-2.6.22-rc-mm/arch/x86_64/kernel/setup.c
> > @@ -949,7 +949,7 @@ static int show_cpuinfo(struct seq_file
> > /* Other (Linux-defined) */
> > "cxmmx", NULL, "cyrix_arr", "centaur_mcr", NULL,
> > "constant_tsc", NULL, NULL,
> > - "up", NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> > + "up", NULL, NULL, NULL, "ida", NULL, NULL, NULL,
> > NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> > NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
>
> Ho hum. This clashes with hpa's git-newsetup tree, which goes for a great
> tromp through the cpuinfo implementation.
>

Hmm.. Will move feature detection to setup routines and will also
refresh the patch against latest mm and resend it

Thanks,
Venki