Re: [PATCH] Display Intel Dynamic Acceleration feature in /proc/cpuinfo

Venki Pallipadi
2007-05-24T21:31:24Z

On Thu, May 24, 2007 at 11:25:27PM +0200, Andi Kleen wrote:
> On Thursday 24 May 2007 23:13:37 Venki Pallipadi wrote:
> > On Thu, May 24, 2007 at 11:08:38PM +0200, Andi Kleen wrote:
> > >
> > > I think it's generally a good idea to push cpuinfo flags in earliest
> > > as possible; just make sure we actually use the final name (so that we don't get
> > > into a pni->sse3 mess again)
> > >
> >
> > ida is official name as in the Software Developer's Manual now. So, should
> > not be a issue unless marketing folks change their mind in future :-)
>
> Well they did sometimes in the past.
>
> But actually reading the patch: it seems weird to detect the flag
> in acpi-cpufreq and essentially change /proc/cpuinfo when a
> module is loaded. Why not in the intel setup function? And why is it
> not in the standard CPUID 1 features mask anyways?
>

I can do it in intel setup function. But, the feature may not be activated
unless the driver is loaded. Going by the hardware capability point
of view, we can do it in setup function.

The feature appears in CPUID 6 (called Power Management Leaf) instead of
regular CPUID 1 features.

Thanks,
Venki