From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: tglx@linutronix.de, mingo@elte.hu
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.21-rt7] PowerPC: fix clockevents for classic CPUs
Date: Thu, 24 May 2007 22:25:30 +0400 [thread overview]
Message-ID: <200705242225.30225.sshtylyov@ru.mvista.com> (raw)
In-Reply-To: <200705172142.26739.sshtylyov@ru.mvista.com>
Uncoditionally set a maximum positive value to the decrementer before calling
an event handler for all "classic" PPC CPUs (although this is only necessary
to clear interrupt on POWER4+, I've been asked to do it this way) -- otherwise
it wouldn't have been done for an offline CPU in periodic mode since the event
reprogramming has been delegated to the timer subsystem.
Also, as the classic decrementer doesn't have periodic mode, make set_mode()
method for this case completely empty.
While at it, add a switch case for CLOCK_EVT_MODE_RESUME to hush the warning.
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
Testing on "classic" CPUs is still needed (used to work atop of 2.6.18-rt7).
arch/powerpc/kernel/time.c | 15 +++++++--------
1 files changed, 7 insertions(+), 8 deletions(-)
Index: linux-2.6/arch/powerpc/kernel/time.c
===================================================================
--- linux-2.6.orig/arch/powerpc/kernel/time.c
+++ linux-2.6/arch/powerpc/kernel/time.c
@@ -166,11 +166,14 @@ static void decrementer_set_mode(enum cl
case CLOCK_EVT_MODE_SHUTDOWN:
tcr &= ~TCR_DIE;
break;
+ case CLOCK_EVT_MODE_RESUME:
+ break;
}
mtspr(SPRN_TCR, tcr);
-#endif
+
if (mode == CLOCK_EVT_MODE_PERIODIC)
decrementer_set_next_event(tb_ticks_per_jiffy, dev);
+#endif
}
static struct clock_event_device decrementer_clockevent = {
@@ -549,16 +552,12 @@ void timer_interrupt(struct pt_regs * re
irq_enter();
#ifdef CONFIG_GENERIC_CLOCKEVENTS
-#ifdef CONFIG_PPC_MULTIPLATFORM
+#if !defined(CONFIG_40x) && !defined(CONFIG_BOOKE)
/*
* We must write a positive value to the decrementer to clear
- * the interrupt on the IBM 970 CPU series. In periodic mode,
- * this happens when the decrementer gets reloaded later, but
- * in one-shot mode, we have to do it here since an event handler
- * may skip loading the new value...
+ * the interrupt on POWER4+ compatible CPUs.
*/
- if (per_cpu(decrementers, cpu).mode != CLOCK_EVT_MODE_PERIODIC)
- set_dec(DECREMENTER_MAX);
+ set_dec(DECREMENTER_MAX);
#endif
/*
* We can't disable the decrementer, so in the period between
next prev parent reply other threads:[~2007-05-24 18:24 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 17:42 [PATCH 2.6.21-rt2] PowerPC: decrementer clockevent driver Sergei Shtylyov
2007-05-17 17:47 ` Kumar Gala
2007-05-17 18:07 ` Sergei Shtylyov
2007-05-17 18:17 ` Kumar Gala
2007-05-17 18:26 ` Sergei Shtylyov
2007-05-17 18:31 ` Kumar Gala
2007-05-17 18:42 ` Sergei Shtylyov
2007-05-18 12:39 ` Matt Sealey
2007-05-18 13:45 ` Sergei Shtylyov
2007-05-18 14:28 ` Matt Sealey
2007-05-18 14:48 ` Thomas Gleixner
2007-05-18 15:37 ` Matt Sealey
2007-05-18 16:31 ` Kumar Gala
2007-05-18 16:50 ` Thomas Gleixner
2007-05-18 16:55 ` Matt Sealey
2007-05-18 16:52 ` Matt Sealey
2007-07-10 10:52 ` Gabriel Paubert
2007-07-10 14:24 ` Segher Boessenkool
2007-07-10 23:31 ` Paul Mackerras
2007-07-11 0:10 ` Segher Boessenkool
2007-05-18 20:27 ` David Miller
2007-05-18 14:56 ` Daniel Walker
2007-05-18 15:06 ` Sergei Shtylyov
2007-05-18 15:39 ` Daniel Walker
2007-05-18 15:48 ` Sergei Shtylyov
2007-05-19 3:33 ` Paul Mackerras
2007-05-20 2:43 ` Daniel Walker
2007-05-20 3:03 ` Benjamin Herrenschmidt
2007-05-20 15:03 ` Matt Sealey
2007-05-20 21:25 ` Benjamin Herrenschmidt
2007-05-20 16:02 ` Segher Boessenkool
2007-05-20 21:26 ` Benjamin Herrenschmidt
2007-05-17 19:27 ` Segher Boessenkool
2007-05-17 19:43 ` Sergei Shtylyov
2007-05-17 19:50 ` Segher Boessenkool
2007-05-17 20:00 ` Sergei Shtylyov
2007-05-17 20:53 ` Segher Boessenkool
2007-05-18 5:04 ` Benjamin Herrenschmidt
2007-05-18 5:39 ` Dave Liu
2007-05-18 7:08 ` Benjamin Herrenschmidt
2007-05-18 13:41 ` Sergei Shtylyov
2007-05-18 13:48 ` Sergei Shtylyov
2007-05-18 23:27 ` Benjamin Herrenschmidt
2007-05-18 23:49 ` Segher Boessenkool
2007-05-19 0:13 ` Benjamin Herrenschmidt
2007-05-19 3:34 ` Paul Mackerras
2007-05-24 18:25 ` Sergei Shtylyov [this message]
2007-05-24 19:10 ` [PATCH 2.6.21-rt7] PowerPC: fix clockevents for classic CPUs Segher Boessenkool
2007-10-18 14:45 ` [PATCH 2.6.21-rt2] PowerPC: decrementer clockevent driver Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705242225.30225.sshtylyov@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox