From: Andi Kleen <ak@suse.de>
To: Venki Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Dave Jones <davej@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Len Brown <len.brown@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Display Intel Dynamic Acceleration feature in /proc/cpuinfo
Date: Thu, 24 May 2007 23:25:27 +0200 [thread overview]
Message-ID: <200705242325.28011.ak@suse.de> (raw)
In-Reply-To: <20070524211337.GB3692@linux-os.sc.intel.com>
On Thursday 24 May 2007 23:13:37 Venki Pallipadi wrote:
> On Thu, May 24, 2007 at 11:08:38PM +0200, Andi Kleen wrote:
> >
> > I think it's generally a good idea to push cpuinfo flags in earliest
> > as possible; just make sure we actually use the final name (so that we don't get
> > into a pni->sse3 mess again)
> >
>
> ida is official name as in the Software Developer's Manual now. So, should
> not be a issue unless marketing folks change their mind in future :-)
Well they did sometimes in the past.
But actually reading the patch: it seems weird to detect the flag
in acpi-cpufreq and essentially change /proc/cpuinfo when a
module is loaded. Why not in the intel setup function? And why is it
not in the standard CPUID 1 features mask anyways?
-Andi
next prev parent reply other threads:[~2007-05-24 21:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 22:46 [PATCH] Display Intel Dynamic Acceleration feature in /proc/cpuinfo Venki Pallipadi
2007-05-24 20:55 ` Andrew Morton
2007-05-24 21:01 ` Dave Jones
2007-05-24 21:08 ` Andi Kleen
2007-05-24 21:13 ` Venki Pallipadi
2007-05-24 21:25 ` Andi Kleen [this message]
2007-05-24 21:28 ` Venki Pallipadi
2007-05-24 21:37 ` Dave Jones
2007-05-24 21:56 ` Andi Kleen
2007-05-24 23:03 ` H. Peter Anvin
2007-05-24 23:13 ` Pallipadi, Venkatesh
2007-05-24 23:23 ` H. Peter Anvin
2007-05-25 0:00 ` Pallipadi, Venkatesh
2007-05-25 0:04 ` H. Peter Anvin
2007-05-30 0:52 ` Venki Pallipadi
2007-05-24 21:10 ` Venki Pallipadi
2007-05-24 22:02 ` Andrew Morton
2007-05-24 22:08 ` Venki Pallipadi
2007-05-24 22:16 ` H. Peter Anvin
2007-05-24 22:14 ` H. Peter Anvin
2007-05-24 22:41 ` Dave Jones
2007-05-24 22:51 ` H. Peter Anvin
2007-05-24 23:06 ` Dave Jones
2007-05-24 23:11 ` H. Peter Anvin
2007-05-24 23:50 ` Alan Cox
2007-05-24 23:53 ` H. Peter Anvin
2007-05-24 22:27 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705242325.28011.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox