From: Andi Kleen <ak@suse.de>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Jay Cliburn <jacliburn@bellsouth.net>,
Grzegorz Krzystek <ninex@ninex.eu.org>,
Andrew Morton <akpm@linux-foundation.org>,
ninex@o2.pl, linux-kernel@vger.kernel.org,
linux-pci@atrey.karlin.mff.cuni.cz,
Michael Ellerman <michael@ellerman.id.au>,
David Miller <davem@davemloft.net>,
Tony Luck <tony.luck@intel.com>,
len.brown@intel.com
Subject: Re: [PATCH 2/2] msi: Add support for the Intel chipsets that support MSI.
Date: Fri, 25 May 2007 07:38:56 +0200 [thread overview]
Message-ID: <200705250738.57066.ak@suse.de> (raw)
In-Reply-To: <m1r6p5cyut.fsf_-_@ebiederm.dsl.xmission.com>
On Friday 25 May 2007 06:26:50 Eric W. Biederman wrote:
>
> This patch is the result of a quick survey of the Intel chipset
> documents. I took a quick look in the document to see if the chipset
> supported MSI and if so I looked through to find the vendor and device
> id of device 0 function 0 of the chipset and added a quirk for that
> device id if I it was not a duplicate.
It would be better to look for any PCI bridge. Sometimes there are
different PCI bridges around (e.g. external PCI-X bridges on HT systems)
which might need own quirks
Also in the x86 world Microsoft defined a FADT ACPI flag that MSI doesn't
work for Vista. It might make sense to do
if (dmi year >= 2007 && FADT.msi_disable not set) assume it works
> This patch should be safe. The anecdotal evidence is that when dealing
> with MSI the Intel chipsets just work. If we find some buggy ones
> changing the list won't be hard.
The FADT bit should be probably checked anyways.
-Andi
next prev parent reply other threads:[~2007-05-25 5:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200705122146.l4CLkH6q012322@fire-2.osdl.org>
[not found] ` <m1mz09p1t7.fsf@ebiederm.dsl.xmission.com>
[not found] ` <20070513014622.c5702928.akpm@linux-foundation.org>
[not found] ` <46470209.9000502@bellsouth.net>
[not found] ` <46470515.50000@NineX.eu.org>
[not found] ` <464707F7.6080600@bellsouth.net>
[not found] ` <m1irawpwy2.fsf@ebiederm.dsl.xmission.com>
[not found] ` <20070513204407.7ba35010@osprey.hogchain.net>
[not found] ` <4647FA38.3090108@NineX.eu.org>
[not found] ` <46480EA5.40400@NineX.eu.org>
[not found] ` <20070514053406.478bf93f@osprey.hogchain.net>
[not found] ` <m1d513oddj.fsf@ebiederm.dsl.xmission.com>
[not found] ` <20070514093829.377e04bc@osprey.hogchain.net>
[not found] ` <m18xbrnyxi.fsf@ebiederm.dsl.xmission.com>
[not found] ` <20070514160005.627435e3@osprey.hogchain.net>
[not found] ` <m1odkmmft4.fsf@ebiederm.dsl.xmission.com>
[not found] ` <20070515212200.517fcba2@osprey.hogchain.net>
[not found] ` <m14pmcmz8r.fsf@ebiederm.dsl.xmission.com>
[not found] ` <20070516185225.3f3ac082@osprey.hogchain.net>
[not found] ` <m1sl9wl28m.fsf@ebiederm.dsl.xmission.com>
[not found] ` <20070522204103.134bf5a2@osprey.hogchain.net>
2007-05-25 4:19 ` [PATCH 1/2] msi: Invert the sense of the MSI enables Eric W. Biederman
2007-05-25 4:26 ` [PATCH 2/2] msi: Add support for the Intel chipsets that support MSI Eric W. Biederman
2007-05-25 5:38 ` Andi Kleen [this message]
2007-05-25 6:10 ` Eric W. Biederman
2007-05-25 14:42 ` Chuck Ebbert
2007-05-25 16:52 ` Eric W. Biederman
2007-05-25 4:31 ` [PATCH 1/2] msi: Invert the sense of the MSI enables Andrew Morton
2007-05-25 5:20 ` Eric W. Biederman
2007-05-25 5:44 ` Grant Grundler
2007-05-25 5:51 ` Andi Kleen
2007-05-25 20:16 ` Jonathan Lundell
2007-05-26 6:52 ` Grant Grundler
2007-05-25 5:14 ` Michael Ellerman
2007-05-25 5:59 ` Eric W. Biederman
2007-05-25 6:40 ` David Miller
2007-05-25 5:20 ` Greg KH
2007-05-25 5:57 ` Eric W. Biederman
2007-05-25 15:17 ` Eric W. Biederman
2007-05-25 15:28 ` Chuck Ebbert
2007-05-25 15:40 ` Roland Dreier
2007-05-25 15:42 ` Roland Dreier
2007-05-25 16:10 ` Eric W. Biederman
2007-05-25 20:09 ` David Schwartz
2007-05-25 20:25 ` Roland Dreier
2007-05-25 20:35 ` Greg KH
2007-05-25 21:06 ` Eric W. Biederman
2007-05-25 21:17 ` Roland Dreier
2007-05-25 21:31 ` Greg KH
2007-05-26 6:43 ` Grant Grundler
2007-05-25 21:47 ` Brice Goglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705250738.57066.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=gregkh@suse.de \
--cc=jacliburn@bellsouth.net \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=michael@ellerman.id.au \
--cc=ninex@ninex.eu.org \
--cc=ninex@o2.pl \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox