public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <andi@firstfloor.org>
Cc: Satyam Sharma <satyam.sharma@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [patch] i386, numaq: enable TSCs again
Date: Fri, 25 May 2007 10:08:27 +0200	[thread overview]
Message-ID: <20070525080827.GA22399@elte.hu> (raw)
In-Reply-To: <20070525075446.GA20140@elte.hu>


Andi, Andrew, do you remember why we disabled TSCs on NUMAQ? It was 
slightly async between CPUs, right? In that case we should try the patch 
below.

	Ingo

--------------------->
Subject: [patch] i386, numaq: enable TSCs again
From: Ingo Molnar <mingo@elte.hu>

enable TSCs on NUMAQ again. sched_clock() got improved and
the scheduler treats it as a per-CPU clock, so there should
be no issues from the slightly async TSCs on NUMAQ. Please
holler if this is wrong ...

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/i386/kernel/numaq.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-cfs-2.6.22-rc2-mm1.q/arch/i386/kernel/numaq.c
===================================================================
--- linux-cfs-2.6.22-rc2-mm1.q.orig/arch/i386/kernel/numaq.c
+++ linux-cfs-2.6.22-rc2-mm1.q/arch/i386/kernel/numaq.c
@@ -81,8 +81,7 @@ int __init get_memcfg_numaq(void)
 static int __init numaq_tsc_disable(void)
 {
 	if (num_online_nodes() > 1) {
-		printk(KERN_DEBUG "NUMAQ: disabling TSC\n");
-		tsc_disable = 1;
+		printk(KERN_DEBUG "NUMAQ: NOT disabling TSC. System still ok?\n");
 	}
 	return 0;
 }


  parent reply	other threads:[~2007-05-25  8:08 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-25  7:10 [patch] sched_clock(): cleanups Ingo Molnar
2007-05-25  7:22 ` Satyam Sharma
2007-05-25  7:25   ` Ingo Molnar
2007-05-25  7:26     ` Ingo Molnar
2007-05-25  7:35       ` Satyam Sharma
2007-05-25  7:39         ` Peter Zijlstra
2007-05-25  7:58           ` Andi Kleen
2007-05-25  8:02             ` Ingo Molnar
2007-05-25  8:16             ` Peter Zijlstra
2007-05-25  8:21               ` Andi Kleen
2007-05-25  7:38       ` Andi Kleen
2007-05-25  7:31   ` Andi Kleen
2007-05-25  7:39     ` Ingo Molnar
2007-05-25  7:43       ` Ingo Molnar
2007-05-25  7:49         ` Ingo Molnar
2007-05-25  7:54           ` [patch] x86_64: fix sched_clock() Ingo Molnar
2007-05-25  8:02             ` Andi Kleen
2007-05-25  8:04               ` Ingo Molnar
2007-05-25  8:20                 ` Andi Kleen
2007-05-25  8:34                   ` Ingo Molnar
2007-05-25  8:41                     ` Andi Kleen
2007-05-25  8:44                       ` Ingo Molnar
2007-05-25  8:45                         ` Andi Kleen
2007-05-25  8:55                           ` Ingo Molnar
2007-05-25  8:55                           ` Andrew Morton
2007-05-25  9:03                             ` Andi Kleen
2007-05-25  9:19                               ` Ingo Molnar
2007-05-25  9:46                                 ` Andi Kleen
2007-05-25 10:12                                   ` Ingo Molnar
2007-05-25 11:20                                     ` Andi Kleen
2007-05-25 11:26                                       ` Ingo Molnar
2007-05-25 11:31                                         ` Ingo Molnar
2007-05-25 11:46                                         ` [patch] sched_clock: fix preempt count imbalance Ingo Molnar
2007-05-25 11:50                                         ` [patch] sched_clock(): cleanups, #2 Ingo Molnar
2007-05-25 11:55                                           ` Andi Kleen
2007-05-25 12:02                                             ` Ingo Molnar
2007-05-25 12:15                                               ` Andi Kleen
2007-05-25 16:17                                                 ` Andrew Morton
2007-05-25 16:26                                                   ` Daniel Walker
2007-05-25 16:33                                                     ` Andi Kleen
2007-05-25 16:49                                               ` Linus Torvalds
2007-05-25 18:08                                                 ` Andi Kleen
2007-05-25 19:14                                                 ` Ingo Molnar
2007-05-25 19:45                                                   ` Linus Torvalds
2007-05-25 10:27                                   ` [patch] x86_64: fix sched_clock() Ingo Molnar
2007-05-25 11:05                               ` Andi Kleen
2007-05-28  3:12                                 ` Rusty Russell
2007-05-25  8:08             ` Ingo Molnar [this message]
2007-05-25  8:19               ` [patch] i386, numaq: enable TSCs again William Lee Irwin III
2007-05-25  8:22                 ` Andi Kleen
2007-05-25  8:25                   ` William Lee Irwin III
2007-05-25  8:31                 ` Ingo Molnar
2007-05-25  8:38                   ` William Lee Irwin III
2007-05-25  8:41                     ` Ingo Molnar
2007-05-25 18:16                       ` Dave Hansen
2007-05-25 18:23                         ` john stultz
2007-05-25  8:15             ` [patch] x86_64: fix sched_clock() Peter Zijlstra
2007-05-25  8:16               ` Ingo Molnar
2007-05-25  8:22           ` [patch] sched_clock(): cleanups Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070525080827.GA22399@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=satyam.sharma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox