Re: [patch] sched_clock(): cleanups, #2

[Andi Kleen <andi@firstfloor.org>]

On Fri, May 25, 2007 at 01:50:04PM +0200, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
> > * Andi Kleen <andi@firstfloor.org> wrote:
> > 
> > > > please send me your current sched-clock.c, i'll redo any remaining 
> > > > cleanups.
> > > 
> > > It needs at least one new preliminary patch (to add on_cpu_single);
> > > please get the series from 
> > > ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches-2.6.22-rc2-git7-070525-1.tar.gz
> > > You need at least tsc-unstable upto paravirt-add-a-sched_clock-paravirt
> > > for everything
> > 
> > thanks.
> > 
> > you missed one patch: please pick up the NUMAQ change i did too. (i 
> > kept the printk to make sure someone notices that and actually tests 
> > thing - i dont have a NUMAQ machine to try this on.)
> > 
> > i'm looking at the other things now.
> 
> find below the cleanups from my first patch that didnt make it into your 
> cleanups. (plus one more cleanup i noticed while merging the missing 
> bits from my first patch) Goes after the bugfix i just sent. Please 
> apply.

I cannot apply it as is because it changes code from the paravirtops
patch too.

BTW to nitpick the original formattings you changed are all probably
standard code style and the new comment is a classical
i++; /* Increase i */

I'll fold the comment change into Jeremy's paravirt ops patch.

-Andi