Re: [patch] sched_clock(): cleanups, #2

[Andi Kleen <andi@firstfloor.org>]

On Fri, May 25, 2007 at 02:02:28PM +0200, Ingo Molnar wrote:
> 
> * Andi Kleen <andi@firstfloor.org> wrote:
> 
> > > find below the cleanups from my first patch that didnt make it into 
> > > your cleanups. (plus one more cleanup i noticed while merging the 
> > > missing bits from my first patch) Goes after the bugfix i just sent. 
> > > Please apply.
> > 
> > I cannot apply it as is because it changes code from the paravirtops 
> > patch too.
> 
> ok - then please merge that single hunk into the paravirtops patch - and 
> leave the other 6 hunks in this patch.

I added the empty lines too.

> 
> > BTW to nitpick the original formattings you changed are all probably 
> > standard code style and the new comment is a classical i++; /* 
> > Increase i */
> 
> could you please quote the portion from my patch that you are talking 
> about?

-static int sc_freq_event(struct notifier_block *nb, unsigned long event,
-                        void *data)
+static int
+sc_freq_event(struct notifier_block *nb, unsigned long event, void *data)

and

+               /*
+                * Still no frequency? Then fall back to tsc_khz:  
+                */
                if (!freq->new)
                        freq->new = tsc_khz;


-Andi (who hopes this thread will end soon now and we can all go
back to more important issues)