From: Andrew Morton <akpm@linux-foundation.org>
To: Greg KH <gregkh@suse.de>
Cc: Matt Mackall <mpm@selenic.com>,
Kay Sievers <kay.sievers@vrfy.org>,
linux-kernel@vger.kernel.org, yi.zhu@intel.com,
Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: Re: 2.6.22-rc2-mm1: NetworkManager fails to find ipw2200 again
Date: Fri, 25 May 2007 17:02:09 -0700 [thread overview]
Message-ID: <20070525170209.40ad51d5.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070525231257.GA9616@suse.de>
On Fri, 25 May 2007 16:12:57 -0700 Greg KH <gregkh@suse.de> wrote:
> On Fri, May 25, 2007 at 06:01:09PM -0500, Matt Mackall wrote:
> > Bisect sequence went 56+ 84+ 98+ 105- 102- 100+ 101+. Looks like 102's
> > to blame:
> >
> > driver-core-check-return-code-of-sysfs_create_link.patch
> >
> > From: Cornelia Huck <cornelia.huck@de.ibm.com>
> >
> > Check for return value of sysfs_create_link() in device_add() and
> > device_rename(). Add helper functions device_add_class_symlinks() and
> > device_remove_class_symlinks() to make the code easier to read.
>
> {sigh}
>
> This wouldn't be the first time this patch has broken things :(
Why does checking these errors cause ipw2200 to fail?
> Andrew, can you drop this from your tree?
Would prefer that we debug things first. It could be that ipw2200 is
trying to create symlinks which already exist. This might indicate a
programming error in ipw2200, which is what the patch is *for*. If it
is indeed an ipw2200 bug then the lesson is that we should have been checking
for errors on day one - that way, we'd never have shipped a buggy ipw2200 driver.
I have an ipw2200 - I'll see if I can reproduce this and I'll add some
debugging code in there. Probably that debugging code should become
permanent.
> Cornelia, can you rework this to not break things?
Things might be already broken?
next prev parent reply other threads:[~2007-05-26 0:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 16:36 2.6.22-rc2-mm1: NetworkManager fails to find ipw2200 again Matt Mackall
2007-05-25 16:48 ` Greg KH
2007-05-25 17:37 ` Kay Sievers
2007-05-25 17:53 ` Matt Mackall
2007-05-25 21:01 ` Matt Mackall
2007-05-25 23:01 ` Matt Mackall
2007-05-25 23:12 ` Greg KH
2007-05-25 23:40 ` Kay Sievers
2007-05-26 0:02 ` Andrew Morton [this message]
2007-05-27 16:15 ` Cornelia Huck
2007-05-25 20:58 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525170209.40ad51d5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cornelia.huck@de.ibm.com \
--cc=gregkh@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox