public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Nigel Cunningham <nigel@nigel.suspend2.net>,
	Maximilian Engelhardt <maxi@daemonizer.de>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: software suspend doesn't work with 2.6.22-rc3
Date: Sat, 26 May 2007 22:23:39 +0200	[thread overview]
Message-ID: <200705262223.39997.rjw@sisk.pl> (raw)
In-Reply-To: <20070526115513.GA8230@gondor.apana.org.au>

On Saturday, 26 May 2007 13:55, Herbert Xu wrote:
> On Sat, May 26, 2007 at 09:14:00PM +1000, Nigel Cunningham wrote:
> > 
> > You have the cryptd Kconfig option in (at least in rc3) - presumably
> > Maximillian has been too keen and turned it on before you were ready :)
> > It does make sense for it to be the problem. Without PF_NOFREEZE set,
> > the refrigerator code will try to get it to enter the freezer, and
> > without the try_to_freeze(), it will just loop and freezing will fail.
> 
> OK that makes sense.  I'll apply your patch.

Please add '#include <freezer.h>' to crypto/cryptd.c for the patch to
compile.

FYI, I'm going to post a patch that will make this try_to_freeze() unnecessary,
but I don't think it'll make it into 2.6.22.

Greetings,
Rafael

  reply	other threads:[~2007-05-26 20:18 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-26  9:28 software suspend doesn't work with 2.6.22-rc3 Maximilian Engelhardt
2007-05-26  9:53 ` Nigel Cunningham
2007-05-26 11:08   ` Herbert Xu
2007-05-26 11:14     ` Nigel Cunningham
2007-05-26 11:55       ` Herbert Xu
2007-05-26 20:23         ` Rafael J. Wysocki [this message]
2007-05-26 12:49   ` Maximilian Engelhardt
2007-05-26 20:20     ` Rafael J. Wysocki
2007-05-26 21:33     ` Nigel Cunningham
2007-05-27 16:01       ` Maximilian Engelhardt
2007-05-27 18:19         ` Rafael J. Wysocki
2007-05-27 20:41           ` Maximilian Engelhardt
2007-05-27 21:27             ` Rafael J. Wysocki
2007-05-28  0:21               ` Maximilian Engelhardt
2007-05-28  7:59                 ` Rafael J. Wysocki
2007-05-28 18:21                   ` Rafael J. Wysocki
2007-05-28 21:02                     ` Maximilian Engelhardt
2007-05-29  0:39                     ` Herbert Xu
2007-05-29 12:01                       ` Rafael J. Wysocki
2007-05-31  6:54                       ` Rafael J. Wysocki
2007-05-31  7:04                         ` Rafael J. Wysocki
2007-05-31  7:13                           ` Rafael J. Wysocki
2007-05-31  8:08                             ` Herbert Xu
2007-05-27 20:35 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705262223.39997.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxi@daemonizer.de \
    --cc=nigel@nigel.suspend2.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox