From: Matthew Garrett <mjg59@srcf.ucam.org>
To: David Brownell <david-b@pacbell.net>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] RTC: Use fallback IRQ if PNP tables don't provide one
Date: Mon, 28 May 2007 18:24:18 +0100 [thread overview]
Message-ID: <20070528172418.GA2076@srcf.ucam.org> (raw)
In-Reply-To: <200705271844.54589.david-b@pacbell.net>
From: Matthew Garrett <mjg59@srcf.ucam.org>
Intel Macs (and possibly other machines) provide a PNP entry for the
RTC, but provide no IRQ. As a result the rtc-cmos driver doesn't allow
wakeup alarms. If the RTC is located at the legacy ioport range, assume
that it's on IRQ 8 unless the tables say otherwise.
Signed-off-by: Matthew Garrett <mjg59@srcf.ucam.org>
---
diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
index 6085261..e24ea82 100644
--- a/drivers/rtc/rtc-cmos.c
+++ b/drivers/rtc/rtc-cmos.c
@@ -641,9 +641,16 @@ cmos_pnp_probe(struct pnp_dev *pnp, const struct pnp_device_id *id)
* drivers can't provide shutdown() methods to disable IRQs.
* Or better yet, fix PNP to allow those methods...
*/
- return cmos_do_probe(&pnp->dev,
- &pnp->res.port_resource[0],
- pnp->res.irq_resource[0].start);
+ if (pnp_port_start(pnp,0) == 0x70 && !pnp_irq_valid(pnp,0))
+ /* Some machines contain a PNP entry for the RTC, but
+ * don't define the IRQ. It should always be safe to
+ * hardcode it in these cases
+ */
+ return cmos_do_probe(&pnp->dev, &pnp->res.port_resource[0], 8);
+ else
+ return cmos_do_probe(&pnp->dev,
+ &pnp->res.port_resource[0],
+ pnp->res.irq_resource[0].start);
}
static void __exit cmos_pnp_remove(struct pnp_dev *pnp)
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2007-05-28 17:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-27 19:03 RTC_DRV_CMOS can break userspace interface Matthew Garrett
2007-05-27 23:39 ` Matthew Garrett
2007-05-28 0:38 ` Matthew Garrett
2007-05-28 1:44 ` David Brownell
2007-05-28 2:16 ` Matthew Garrett
2007-05-28 17:24 ` Matthew Garrett [this message]
2007-05-28 18:50 ` [PATCH] RTC: Use fallback IRQ if PNP tables don't provide one Matthieu CASTET
2007-05-30 0:30 ` Andrew Morton
2007-05-30 1:02 ` Matthew Garrett
2007-05-28 21:06 ` David Brownell
2007-05-28 1:36 ` RTC_DRV_CMOS can break userspace interface David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070528172418.GA2076@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox