From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM/ARM26: Enable arbitary speed tty ioctls and split input/output speed
Date: Mon, 28 May 2007 20:36:58 +0100 [thread overview]
Message-ID: <20070528193658.GF5737@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20070523172739.1d3a918c@the-village.bc.nu>
On Wed, May 23, 2007 at 05:27:39PM +0100, Alan Cox wrote:
> Add the ioctls and values needed for this to the ARM26/ARM32 ports. The
> actual code has been in the base kernel for a while and automatically
> turns on when a port sets the required defines.
Did you forget to provide a termios2 structure for ARM? Hope you
remembered for the other arches:
drivers/char/tty_ioctl.c: In function `set_termios':
drivers/char/tty_ioctl.c:429: error: invalid application of `sizeof' to incomplete type `termios2'
drivers/char/tty_ioctl.c: In function `n_tty_ioctl':
drivers/char/tty_ioctl.c:732: error: invalid application of `sizeof' to incomplete type `termios2'
Will copy the i386 version into ARM's termbits.h
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-05-28 19:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 16:27 [PATCH] ARM/ARM26: Enable arbitary speed tty ioctls and split input/output speed Alan Cox
2007-05-23 16:27 ` Russell King
2007-05-24 13:08 ` [PATCH] $ARCH: " David Woodhouse
2007-05-24 13:41 ` Alan Cox
2007-05-24 13:45 ` David Woodhouse
2007-05-24 15:05 ` Alan Cox
2007-05-24 15:18 ` David Woodhouse
2007-05-28 4:47 ` Paul Mackerras
2007-06-06 12:33 ` David Woodhouse
2007-06-08 11:18 ` [PATCH] PowerPC: " David Woodhouse
2007-06-06 12:30 ` [SERIAL] Don't optimise away baud rate changes when BOTHER is used David Woodhouse
2007-06-06 15:03 ` Alan Cox
2007-06-06 17:29 ` David Woodhouse
2007-06-07 15:38 ` Alan Cox
2007-06-07 15:50 ` David Woodhouse
2007-06-07 21:55 ` Alan Cox
2007-06-07 22:04 ` David Woodhouse
2007-06-07 22:15 ` David Woodhouse
2007-06-07 22:54 ` Alan Cox
2007-06-08 11:01 ` David Woodhouse
2007-06-08 11:48 ` Alan Cox
2007-06-08 11:48 ` David Woodhouse
2007-06-08 11:13 ` David Woodhouse
2007-06-08 11:14 ` [SERIAL] Don't optimise away baud rate changes when BOTHER is used (v2) David Woodhouse
2007-06-08 11:42 ` Alan Cox
2007-06-06 12:34 ` [PATCH] Minor cleanups in tty_ioctl.c David Woodhouse
2007-06-06 13:09 ` Jiri Slaby
2007-05-28 19:36 ` Russell King [this message]
2007-05-28 21:56 ` [PATCH] ARM/ARM26: Enable arbitary speed tty ioctls and split input/output speed Andrew Morton
2007-05-28 22:00 ` Russell King
2007-05-29 8:31 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070528193658.GF5737@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox