From: David Miller <davem@davemloft.net>
To: rpjday@mindspring.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: dead CONFIG_ variables: net/ipv4/
Date: Tue, 29 May 2007 13:10:13 -0700 (PDT) [thread overview]
Message-ID: <20070529.131013.97289989.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0705021711450.16967@localhost.localdomain>
From: "Robert P. J. Day" <rpjday@mindspring.com>
Date: Wed, 2 May 2007 17:15:01 -0400 (EDT)
>
> again, this list contains some CONFIG_ variables that aren't
> technically dead, but *really* should be renamed to not be confused
> with Kconfig variables. there are, however, legitimately dead ones in
> the following in places:
>
> $ ../dead_config.sh net/ipv4
> ========== IP_FIB_TRIE_STATS ==========
> net/ipv4/fib_trie.c:#undef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#endif /* CONFIG_IP_FIB_TRIE_STATS */
Robert Olsson uses this for statistics collection by turning
that #undef there into a #define and other developers could
use this too.
Therefore I'm reluctant to remove this for now.
> ========== IP_NOSIOCRT ==========
> net/ipv4/fib_frontend.c:#ifndef CONFIG_IP_NOSIOCRT
Definitely bogus, deleted.
> ========== IP_PIMSM ==========
> net/ipv4/ipmr.c:#define CONFIG_IP_PIMSM 1
This one isn't bogus, it is a shorthand and is set when
either CONFIG_IP_PIMSM_V1 or CONFIG_IP_PIMSM_V2 are set.
> ========== IP_ROUTE_PERVASIVE ==========
> net/ipv4/fib_semantics.c:#ifdef CONFIG_IP_ROUTE_PERVASIVE
This seems to be for an intended feature to allow control of
recursive gateway lookups, I'm not touching this one :-)
next prev parent reply other threads:[~2007-05-29 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 21:15 dead CONFIG_ variables: net/ipv4/ Robert P. J. Day
2007-05-03 3:23 ` Patrick McHardy
2007-05-29 20:10 ` David Miller [this message]
2007-05-29 20:14 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070529.131013.97289989.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox