From: Christoph Hellwig <hch@infradead.org>
To: Dave Jones <davej@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Keith Packard <keithp@keithp.com>, Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH 1/2] [AGPGART] intel_agp: cleanup intel private data
Date: Tue, 29 May 2007 10:13:40 +0100 [thread overview]
Message-ID: <20070529091340.GA27950@infradead.org> (raw)
In-Reply-To: <20070529062005.GA5097@zhen-devel.sh.intel.com>
On Tue, May 29, 2007 at 02:20:05PM +0800, Wang Zhenyu wrote:
> +static struct _intel_private {
> + struct pci_dev *pcidev; /* device one */
> volatile u8 __iomem *registers;
> + volatile u32 __iomem *gtt; /* I915G */
Neither of these should be volatile.
prev parent reply other threads:[~2007-05-29 9:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 6:20 [PATCH 1/2] [AGPGART] intel_agp: cleanup intel private data Wang Zhenyu
2007-05-29 9:13 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070529091340.GA27950@infradead.org \
--to=hch@infradead.org \
--cc=davej@redhat.com \
--cc=eric@anholt.net \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox