From: Andi Kleen <andi@firstfloor.org>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Andy Whitcroft <apw@shadowen.org>, Andrew Morton <akpm@osdl.org>,
Randy Dunlap <rdunlap@xenotime.net>,
Joel Schopp <jschopp@austin.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add a trivial patch style checker
Date: Tue, 29 May 2007 15:19:03 +0200 [thread overview]
Message-ID: <20070529131903.GA5024@one.firstfloor.org> (raw)
In-Reply-To: <20070529115324.GB18437@osiris.boeblingen.de.ibm.com>
On Tue, May 29, 2007 at 01:53:24PM +0200, Heiko Carstens wrote:
> On Tue, May 29, 2007 at 04:23:45AM +0200, Andi Kleen wrote:
> > Possible further checks that might make sense:
> > - panic() anywhere in drivers/*
>
> A driver should be allowed to panic. E.g. if it detects that due to a
> firmware or driver bug memory corruption happened. IMHO the best thing
> to do then is panic.
That is not how Linux normally operates. A BUG() doesn't panic() by
default either.
And on systems with IOMMU that is exactly the wrong thing to do.
Besides the problem is that bad drivers tend to badly abuse it
(e.g. see some particular BSD derviced SCSI drivers). We definitely
don't want any more of such code.
-Andi
next prev parent reply other threads:[~2007-05-29 13:19 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-27 17:11 [PATCH] add a trivial patch style checker Andy Whitcroft
2007-05-27 17:10 ` Randy Dunlap
2007-05-28 10:48 ` Andy Whitcroft
2007-05-29 15:00 ` Joel Schopp
2007-05-27 17:49 ` Andreas Schwab
2007-05-27 21:49 ` Dave Jones
2007-05-28 0:18 ` Andrew Morton
2007-05-28 12:10 ` Andy Whitcroft
2007-05-28 9:13 ` Sam Ravnborg
2007-05-28 9:45 ` Jan Engelhardt
2007-05-29 9:01 ` Andy Whitcroft
2007-05-29 16:12 ` Joel Schopp
2007-05-29 16:20 ` Julio M. Merino Vidal
2007-05-29 20:00 ` Jan Engelhardt
2007-05-29 1:51 ` Qi Yong
2007-05-29 2:23 ` Andi Kleen
2007-05-29 9:05 ` Andy Whitcroft
2007-05-29 20:22 ` Jan Engelhardt
2007-05-29 22:36 ` Randy Dunlap
2007-05-30 8:34 ` Jan Engelhardt
2007-05-30 15:33 ` Randy Dunlap
2007-05-30 16:04 ` Jan Engelhardt
2007-05-31 12:07 ` [PATCH] add a trivial patch style checker II Andi Kleen
2007-05-31 19:59 ` Dave Jones
2007-06-01 14:18 ` Andy Whitcroft
2007-05-29 11:53 ` [PATCH] add a trivial patch style checker Heiko Carstens
2007-05-29 13:19 ` Andi Kleen [this message]
2007-05-29 14:22 ` Heiko Carstens
2007-05-29 14:58 ` Andi Kleen
2007-05-29 16:43 ` Heiko Carstens
2007-05-29 23:21 ` Andi Kleen
2007-05-29 18:55 ` Andy Whitcroft
2007-05-29 21:07 ` [PATCH] add a trivial patch style checker v2 Andy Whitcroft
2007-05-29 22:42 ` Joel Schopp
2007-06-06 12:40 ` Geert Uytterhoeven
2007-06-06 15:04 ` Dave Jones
2007-06-06 18:35 ` Andy Whitcroft
2007-05-31 19:26 ` [PATCH] add a trivial patch style checker Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070529131903.GA5024@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox