From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761302AbXE2NWT (ORCPT ); Tue, 29 May 2007 09:22:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753113AbXE2NWF (ORCPT ); Tue, 29 May 2007 09:22:05 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:49437 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbXE2NWE (ORCPT ); Tue, 29 May 2007 09:22:04 -0400 Date: Tue, 29 May 2007 14:21:58 +0100 From: Christoph Hellwig To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Andrew Morton , Ingo Molnar , Bill Huey , Jason Baron , Steven Rostedt , Christoph Hellwig Subject: Re: [PATCH 2/5] lockdep: sanitise CONFIG_PROVE_LOCKING Message-ID: <20070529132158.GA2192@infradead.org> Mail-Followup-To: Christoph Hellwig , Peter Zijlstra , linux-kernel@vger.kernel.org, Andrew Morton , Ingo Molnar , Bill Huey , Jason Baron , Steven Rostedt References: <20070529125248.877196281@chello.nl> <20070529130106.864404378@chello.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070529130106.864404378@chello.nl> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 29, 2007 at 02:52:50PM +0200, Peter Zijlstra wrote: > Ensure that all of the lock dependency tracking code is under > CONFIG_PROVE_LOCKING. This allows us to use the held lock tracking code > for other purposes. There's an awfull lot of ifdefs introduced in this patch, I wonder whether it might be better to split up lockdep.c at those boundaries.