[PATCH 1/1] Work around Dell E520 BIOS reboot bug.

[PATCH 1/1] Work around Dell E520 BIOS reboot bug.

[Tim Gardner]

From: Tim Gardner <tim.gardner@ubuntu.com>
Subject: [PATCH] Work around Dell E520 BIOS reboot bug.

Force Dell E520 to use the BIOS to shutdown/reboot.

Signed-off-by: Tim Gardner <tim.gardner@ubuntu.com>
---

I have at least one report that this patch fixes shutdown/reboot
problems on the Dell E520 platform.

 arch/i386/kernel/reboot.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/i386/kernel/reboot.c b/arch/i386/kernel/reboot.c
index 3514b41..e33f51a 100644
--- a/arch/i386/kernel/reboot.c
+++ b/arch/i386/kernel/reboot.c
@@ -88,6 +88,14 @@ static int __init set_bios_reboot(struct dmi_system_id *d)
 }
 
 static struct dmi_system_id __initdata reboot_dmi_table[] = {
+	{	/* Handle problems with rebooting on Dell E520's */
+		.callback = set_bios_reboot,
+		.ident = "Dell E520",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Dell DM061"),
+		},
+	},
 	{	/* Handle problems with rebooting on Dell 1300's */
 		.callback = set_bios_reboot,
 		.ident = "Dell PowerEdge 1300",
-- 
1.4.4.2

Re: [PATCH 1/1] Work around Dell E520 BIOS reboot bug.

[Matt Domsch]

On Wed, May 23, 2007 at 01:12:44PM -0600, Tim Gardner wrote:
> From: Tim Gardner <tim.gardner@ubuntu.com>
> Subject: [PATCH] Work around Dell E520 BIOS reboot bug.
> 
> Force Dell E520 to use the BIOS to shutdown/reboot.
> 
> Signed-off-by: Tim Gardner <tim.gardner@ubuntu.com>

Acked-by: Matt Domsch <Matt_Domsch@dell.com>

Thanks Tim for submitting this.
-Matt

-- 
Matt Domsch
Software Architect
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

Re: [PATCH 1/1] Work around Dell E520 BIOS reboot bug.

[Andrew Morton]

On Fri, 25 May 2007 21:58:09 -0500
Matt Domsch <Matt_Domsch@dell.com> wrote:

> On Wed, May 23, 2007 at 01:12:44PM -0600, Tim Gardner wrote:
> > From: Tim Gardner <tim.gardner@ubuntu.com>
> > Subject: [PATCH] Work around Dell E520 BIOS reboot bug.
> > 
> > Force Dell E520 to use the BIOS to shutdown/reboot.
> > 
> > Signed-off-by: Tim Gardner <tim.gardner@ubuntu.com>
> 
> Acked-by: Matt Domsch <Matt_Domsch@dell.com>
> 
> Thanks Tim for submitting this.

Do you think this is also required in 2.6.21.x?

Andi: ack for 2.6.22 inclusion?

Thanks.



From: Tim Gardner <tim.gardner@ubuntu.com>

Force Dell E520 to use the BIOS to shutdown/reboot.

I have at least one report that this patch fixes shutdown/reboot
problems on the Dell E520 platform.

Signed-off-by: Tim Gardner <tim.gardner@ubuntu.com>
Cc: Andi Kleen <ak@suse.de>
Acked-by: Matt Domsch <Matt_Domsch@dell.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 arch/i386/kernel/reboot.c |    8 ++++++++
 1 files changed, 8 insertions(+)

diff -puN arch/i386/kernel/reboot.c~work-around-dell-e520-bios-reboot-bug arch/i386/kernel/reboot.c
--- a/arch/i386/kernel/reboot.c~work-around-dell-e520-bios-reboot-bug
+++ a/arch/i386/kernel/reboot.c
@@ -89,6 +89,14 @@ static int __init set_bios_reboot(struct
 }
 
 static struct dmi_system_id __initdata reboot_dmi_table[] = {
+	{	/* Handle problems with rebooting on Dell E520's */
+		.callback = set_bios_reboot,
+		.ident = "Dell E520",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Dell DM061"),
+		},
+	},
 	{	/* Handle problems with rebooting on Dell 1300's */
 		.callback = set_bios_reboot,
 		.ident = "Dell PowerEdge 1300",
_

Re: [PATCH 1/1] Work around Dell E520 BIOS reboot bug.

[Andi Kleen]

On Wednesday 30 May 2007 00:33, Andrew Morton wrote:
> On Fri, 25 May 2007 21:58:09 -0500
>
> Matt Domsch <Matt_Domsch@dell.com> wrote:
> > On Wed, May 23, 2007 at 01:12:44PM -0600, Tim Gardner wrote:
> > > From: Tim Gardner <tim.gardner@ubuntu.com>
> > > Subject: [PATCH] Work around Dell E520 BIOS reboot bug.
> > >
> > > Force Dell E520 to use the BIOS to shutdown/reboot.
> > >
> > > Signed-off-by: Tim Gardner <tim.gardner@ubuntu.com>
> >
> > Acked-by: Matt Domsch <Matt_Domsch@dell.com>
> >
> > Thanks Tim for submitting this.
>
> Do you think this is also required in 2.6.21.x?

People can always set the boot option. It hardly seems like a critical issue
needing a backport.

> Andi: ack for 2.6.22 inclusion?

Ok. 

At some point we'll likely need to change the default anyways; the 
keyboard controller method seems to become flakier and flakier.
I was actually thinking about using ACPI reset instead though.

-Andi