From: Pete Zaitcev <zaitcev@redhat.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: "Satyam Sharma" <satyam.sharma@gmail.com>,
"Matthias Kaehlcke" <matthias.kaehlcke@gmail.com>,
linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, zaitcev@redhat.com
Subject: Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
Date: Wed, 30 May 2007 17:05:30 -0700 [thread overview]
Message-ID: <20070530170530.08a77359.zaitcev@redhat.com> (raw)
In-Reply-To: <adaodk1q3ny.fsf@cisco.com>
On Wed, 30 May 2007 16:42:41 -0700, Roland Dreier <rdreier@cisco.com> wrote:
> If I just see
>
> for (pos = list_entry((head)->next, typeof(*pos), member),
> n = list_entry(pos->member.next, typeof(*pos), member);
> &pos->member != (head);
> pos = n, n = list_entry(n->member.next, typeof(*n), member))
>
> then what am I to think?
You won't catch me writing this kind of crap, so the question is moot.
Seriously, a comma operator? Admit it, you just expanded a marcro from
list.h by hand. Real people cannot write like that.
-- Pete
next prev parent reply other threads:[~2007-05-31 0:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 8:47 [PATCH] drivers/block/ub.c: use list_for_each_entry() Matthias Kaehlcke
2007-05-30 19:38 ` Pete Zaitcev
2007-05-30 20:28 ` Matthias Kaehlcke
2007-05-30 21:14 ` Satyam Sharma
2007-05-30 23:08 ` Pete Zaitcev
2007-05-30 23:14 ` Roland Dreier
2007-05-30 23:32 ` Pete Zaitcev
2007-05-30 23:42 ` Roland Dreier
2007-05-31 0:05 ` Pete Zaitcev [this message]
2007-05-31 4:28 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070530170530.08a77359.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=matthias.kaehlcke@gmail.com \
--cc=rdreier@cisco.com \
--cc=satyam.sharma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox