From: Oleg Nesterov <oleg@tv-sign.ru>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: Stephen Hemminger <shemminger@osdl.org>,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: + fix-soft-lockup-when-removing-netconsole-module.patch added to -mm tree
Date: Thu, 31 May 2007 01:01:37 +0400 [thread overview]
Message-ID: <20070530210137.GA225@tv-sign.ru> (raw)
Jason Wessel wrote:
>
> The netpoll_cleanup handler can hang the kernel if there is no work in the
> work queue because a call to cancel_rearming_delayed_work() with no work
> goes into an infinite loop.
This should not be true any longer, cancel_rearming_delayed_work() should work
correctly in any case.
Could you please clarify?
> @@ -771,30 +771,32 @@ void netpoll_cleanup(struct netpoll *np)
>
> [...snip...]
>
> + if (atomic_dec_and_test(&npinfo->refcnt)) {
> + skb_queue_purge(&npinfo->arp_tx);
> + skb_queue_purge(&npinfo->txq);
> + if (delayed_work_pending(&npinfo->tx_work)) {
> cancel_rearming_delayed_work(&npinfo->tx_work);
> flush_scheduled_work();
But this "if (delayed_work_pending())" is racy anyway?
Oleg.
next reply other threads:[~2007-05-30 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 21:01 Oleg Nesterov [this message]
2007-05-30 21:51 ` + fix-soft-lockup-when-removing-netconsole-module.patch added to -mm tree Andrew Morton
2007-05-30 22:27 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070530210137.GA225@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox