From: Andrew Morton <akpm@linux-foundation.org>
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: "Andi Kleen" <ak@suse.de>, "Russell King" <rmk@arm.linux.org.uk>,
"Bjorn Helgaas" <bjorn.helgaas@hp.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] serial: convert early_uart to earlycon for 8250
Date: Wed, 30 May 2007 21:39:34 -0700 [thread overview]
Message-ID: <20070530213934.0a55d86f.akpm@linux-foundation.org> (raw)
In-Reply-To: <86802c440705302134l637df0fbm9a3b99eff19201@mail.gmail.com>
On Wed, 30 May 2007 21:34:35 -0700 "Yinghai Lu" <yhlu.kernel@gmail.com> wrote:
> they will need
> diff --git a/include/asm-x86_64/io.h b/include/asm-x86_64/io.h
> index de2cd9a..e2d66de 100644
> --- a/include/asm-x86_64/io.h
> +++ b/include/asm-x86_64/io.h
> @@ -145,6 +145,19 @@ extern void early_iounmap(void *addr, unsigned long size);
> extern void __iomem * ioremap_nocache (unsigned long offset, unsigned
> long size);
> extern void iounmap(volatile void __iomem *addr);
>
> +#include <asm/pgtable.h>
> +#include <asm/fixmap.h>
> +
> +static inline void __iomem * fix_ioremap (unsigned idx, unsigned long phys)
> +{
> + void __iomem * vaddr;
> + set_fixmap_nocache(idx, phys & PAGE_MASK);
> + vaddr = (void __iomem *)__fix_to_virt(idx);
> + vaddr += phys & ~PAGE_MASK;
> +
> + return vaddr;
> +}
> +
I hope not - I just removed that inlined function. It's too large and the
inclusion of pgtable.h in io.h causes all sorts of problems.
This function should go into arch/.../mm/ioremap.c
next prev parent reply other threads:[~2007-05-31 4:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 1:43 [PATCH 4/5] serial: convert early_uart to earlycon for 8250 Yinghai Lu
2007-05-30 18:57 ` Andrew Morton
2007-05-30 19:58 ` Yinghai Lu
2007-05-30 20:18 ` Andrew Morton
2007-05-30 20:58 ` Yinghai Lu
2007-05-30 21:48 ` Andrew Morton
2007-05-31 3:13 ` Andrew Morton
2007-05-31 4:34 ` Yinghai Lu
2007-05-31 4:36 ` Yinghai Lu
2007-05-31 4:48 ` Andrew Morton
2007-05-31 15:17 ` Bjorn Helgaas
2007-05-31 16:32 ` Yinghai Lu
2007-05-31 16:45 ` Bjorn Helgaas
2007-05-31 18:49 ` Yinghai Lu
2007-05-31 4:39 ` Andrew Morton [this message]
2007-05-31 4:42 ` Yinghai Lu
2007-05-31 4:51 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2007-05-31 21:01 Yinghai Lu
2007-05-31 23:54 ` Andrew Morton
2007-06-01 0:11 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070530213934.0a55d86f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@suse.de \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox