From: Christoph Hellwig <hch@infradead.org>
To: Len Brown <lenb@kernel.org>
Cc: Andi Drebes <lists-receive@programmierforen.de>,
kernel-janitors@lists.osdl.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE
Date: Thu, 31 May 2007 10:56:03 +0100 [thread overview]
Message-ID: <20070531095603.GA24654@infradead.org> (raw)
In-Reply-To: <200705301525.05905.lenb@kernel.org>
On Wed, May 30, 2007 at 03:25:05PM -0400, Len Brown wrote:
>
> > > Any reason to not just replace ACPI_RSD_TABLE_SIZE with ARRAY_SIZE?
>
> Probably because ARRAY_SIZE doesn't exist in ACPICA, which is
> where this code comes from...
>
> When we change syntax in ACPICA files in Linux to make it more "beautiful",
> then it creates more work for me -- as forever on, that syntax difference
> must be manually compared to upstream ACPICA and Linux -- and that syntax
> difference causes upstream patches to no longer apply and require
> hand merging.
Or we could stop that ACPCICA crap ASAP. The acpi code not only looks
like crap because of that but it's buggy as hell now.
Intel is claiming how great linux is and how supportive is to it, but
can't even write proper code for their abomination of a firmware standard.
This is really more than dishonest. Please take patches to get acpi into
shape and stop this complaining.
next parent reply other threads:[~2007-05-31 9:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200705261239.27485.lists-receive@programmierforen.de>
[not found] ` <46581C06.7000005@student.ltu.se>
[not found] ` <200705261558.24912.lists-receive@programmierforen.de>
[not found] ` <200705301525.05905.lenb@kernel.org>
2007-05-31 9:56 ` Christoph Hellwig [this message]
2007-06-10 10:57 ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Pavel Machek
2007-06-10 21:44 ` Bjorn Helgaas
2007-06-12 18:41 ` Andi Drebes
2007-06-12 18:53 ` Bjorn Helgaas
2007-06-13 21:21 ` Andi Drebes
2007-06-15 17:56 ` Andi Drebes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070531095603.GA24654@infradead.org \
--to=hch@infradead.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists-receive@programmierforen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox