From: Christoph Hellwig <hch@infradead.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Jens Axboe <jens.axboe@oracle.com>,
linux-kernel@vger.kernel.org, cotte@de.ibm.com, neilb@suse.de,
zanussi@us.ibm.com, Linus Torvalds <torvalds@osdl.org>,
hch@infradead.org
Subject: Re: [PATCH] sendfile removal
Date: Thu, 31 May 2007 18:31:43 +0100 [thread overview]
Message-ID: <20070531173143.GA7605@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0705311750180.12688@blonde.wat.veritas.com>
On Thu, May 31, 2007 at 06:06:19PM +0100, Hugh Dickins wrote:
> Christoph already picked up on that, and it's of interest to shmem too:
> loop over tmpfs in 2.6 was relying on shmem_file_sendfile, for which
> the generic route is not good enough.
>
> If we're giving a .splice_read to everything which used to have a
> .sendfile, then I think you just need to make do_lo_read() use
> ->splice_read now?
I'd be perfectly happy with killing support for using ->read. Any
simple filesystem can use the generic methods, and any more complex
filesystem should better have splice aswell. Btw, someone should
look into using splice for the loop write path aswell, the current
useage of ->prepare_write and ->commit_write has similar locking
problems aswell.
next prev parent reply other threads:[~2007-05-31 17:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 10:33 [PATCH] sendfile removal Jens Axboe
2007-05-31 10:47 ` Jens Axboe
2007-05-31 10:47 ` Eric Dumazet
2007-05-31 10:53 ` Jens Axboe
2007-06-01 4:09 ` H. Peter Anvin
2007-06-01 5:41 ` Jens Axboe
2007-06-01 5:50 ` H. Peter Anvin
2007-06-01 7:22 ` Eric Dumazet
2007-06-01 15:52 ` H. Peter Anvin
2007-06-01 16:18 ` Linus Torvalds
2007-06-01 16:47 ` Eric Dumazet
2007-06-01 16:53 ` H. Peter Anvin
2007-06-02 15:02 ` Jens Axboe
2007-06-02 15:01 ` Jens Axboe
2007-06-02 15:40 ` Linus Torvalds
2007-06-02 16:35 ` Jens Axboe
[not found] ` <20070603130507.GA11170@mail.ustc.edu.cn>
2007-06-03 13:05 ` Fengguang Wu
[not found] ` <20070603142931.GA5916@mail.ustc.edu.cn>
2007-06-03 14:29 ` Fengguang Wu
[not found] ` <20070604004647.GA8076@mail.ustc.edu.cn>
2007-06-04 0:46 ` Fengguang Wu
2007-06-04 8:05 ` Jens Axboe
[not found] ` <20070604112214.GA7457@mail.ustc.edu.cn>
2007-06-04 11:22 ` Fengguang Wu
2007-06-01 16:22 ` Pádraig Brady
2007-05-31 10:55 ` Christoph Hellwig
2007-05-31 11:05 ` Jens Axboe
2007-05-31 12:26 ` Neil Brown
2007-05-31 12:27 ` Jens Axboe
2007-06-01 2:44 ` [PATCH] sendfile removal (nfsd update) Neil Brown
2007-06-01 5:44 ` Jens Axboe
2007-06-01 8:01 ` Jens Axboe
2007-06-01 8:15 ` [PATCH] sendfile removal Jens Axboe
2007-05-31 11:04 ` Carsten Otte
2007-05-31 11:06 ` Jens Axboe
2007-05-31 15:33 ` Tom Zanussi
2007-05-31 19:01 ` Jens Axboe
2007-05-31 17:06 ` Hugh Dickins
2007-05-31 17:31 ` Christoph Hellwig [this message]
2007-05-31 19:03 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070531173143.GA7605@infradead.org \
--to=hch@infradead.org \
--cc=cotte@de.ibm.com \
--cc=hugh@veritas.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=torvalds@osdl.org \
--cc=zanussi@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox