From: Jeff Dike <jdike@addtoit.com>
To: Zach Brown <zach.brown@oracle.com>, Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: [PATCH] Syslets - Fix cachemiss_thread return value
Date: Thu, 31 May 2007 14:19:23 -0400 [thread overview]
Message-ID: <20070531181923.GA9904@c2.user-mode-linux.org> (raw)
cachemiss_thread should explicitly return 0 or error instead of
task_ret_reg(current) (which is -ENOSYS anyway) because
async_thread_helper is careful to put the return value in eax anyway.
On x86_64, it looks like async_child_rip is similarly careful.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
--
kernel/async.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6/kernel/async.c
===================================================================
--- linux-2.6.orig/kernel/async.c 2007-05-29 20:11:11.000000000 -0400
+++ linux-2.6/kernel/async.c 2007-05-31 14:12:49.000000000 -0400
@@ -575,7 +575,7 @@ static long cachemiss_thread(void *data)
struct task_struct *t = current;
struct async_head *ah = args->ah;
struct async_thread *at;
- int ret;
+ int ret = 0;
at = &t->__at;
async_thread_init(t, at, ah);
@@ -607,7 +607,7 @@ static long cachemiss_thread(void *data)
complete(&ah->start_done);
async_cachemiss_loop(at, ah, t);
- return task_ret_reg(t);
+ return ret;
}
/**
next reply other threads:[~2007-05-31 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 18:19 Jeff Dike [this message]
2007-05-31 20:09 ` [PATCH] Syslets - Fix cachemiss_thread return value Ingo Molnar
2007-05-31 22:07 ` Zach Brown
2007-05-31 23:39 ` Jeff Dike
2007-06-01 0:00 ` Zach Brown
2007-06-07 23:27 ` Zach Brown
2007-06-08 16:10 ` Jeff Dike
2007-06-08 16:26 ` Zach Brown
2007-06-08 16:33 ` Jeff Dike
2007-06-08 16:46 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070531181923.GA9904@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox