Re: [patch 8/9] F00F bug fixup for i386 - use conditional calls

Mathieu Desnoyers
2007-05-31T21:08:11Z

* Andrew Morton (akpm@linux-foundation.org) wrote:

> > Use the faster conditional calls for F00F bug handling in do_page_fault.
> >
>
> I guess this means that CONDCALL will be enabled on pretty much all i386,
> in which case making the whole feature Kconfigurable is starting to look
> marginal.
>
> Perhaps a better approach would have to made this change dependent upon
> CONDCALL, rather than forcing it on.
>

Do you mean making X86_F00F_BUG depend on COND_CALL instead of selecting
it ?

> > + if (cond_call(fix_f00f, do_f00f_workaround(regs, address)))
> > + return;
>
> We do a cond_call() to an inlined function? That's a bit weird, isn't it?
>

Yes, but it works :) I will add this information to the documentation.