Re: [patch 9/9] Scheduler profiling - Use conditional calls

Mathieu Desnoyers
2007-05-31T21:13:15Z

* William Lee Irwin III (wli@holomorphy.com) wrote:
> On Wed, May 30, 2007 at 10:00:34AM -0400, Mathieu Desnoyers wrote:
> > Use conditional calls with lower d-cache hit in optimized version as a
> > condition for scheduler profiling call.
> [...]
> > + if (prof_on)
> > + BUG_ON(cond_call_arm("profile_on"));
>
> What's the point of this BUG_ON()? The condition is a priori impossible.
>

Not impossible: hash_add_cond_call() can return -ENOMEM if kmalloc lacks
memory.

Mathieu