Re: [PATCH] quiet down swiotlb warnings

Andi Kleen
2007-06-01T19:47:42Z

On Fri, Jun 01, 2007 at 03:38:57PM -0400, Rik van Riel wrote:
> Andi Kleen wrote:
>
> >An pci_map_sg failing typically leads to an IO error and we've
> >always printk'ed those. Otherwise people will wonder why they
> >get EIO.
>
> In some situations. In this case the qla2xxx driver uses
> the pci_map_sg() failure as a throttling mechanism and

First WTF does it need swiotlb anyways? QA hardware should
be definitely DAC capable, shouldn't it?

> printing out all the warnings will actually slow down the
> system.

Another reason is that there is a lot of code that
still doesn't check the return values and when that
happens you might get data corruption too.

>
> Andi, what do you propose as a solution?

A different interface; like I wrote in my earlier mail.

Another probabibility would be to have a blocking interface
to swiotlb that won't fail. That would be the better solution
long term, but i was told it is hard to fit into some current
driver interfaces.

-Andi