From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759870AbXFBHHE (ORCPT ); Sat, 2 Jun 2007 03:07:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754981AbXFBHG4 (ORCPT ); Sat, 2 Jun 2007 03:06:56 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:41271 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754785AbXFBHGz (ORCPT ); Sat, 2 Jun 2007 03:06:55 -0400 Date: Sat, 2 Jun 2007 00:06:45 -0700 From: Andrew Morton To: Cyrill Gorcunov Cc: Eric Sandeen , Jan Kara , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] Fix possible leakage of blocks in UDF Message-Id: <20070602000645.508ddf93.akpm@linux-foundation.org> In-Reply-To: <20070602065923.GB8387@cvg> References: <20070524170554.GC19709@duck.suse.cz> <20070524203653.GA7693@duck.suse.cz> <465DF0B4.2050203@sandeen.net> <20070601211036.GA23975@duck.suse.cz> <46609FBD.5040407@sandeen.net> <20070601154834.53558d1b.akpm@linux-foundation.org> <4660FD7F.4090302@sandeen.net> <20070601224339.c803e04e.akpm@linux-foundation.org> <20070602063403.GA8387@cvg> <20070601235422.fdc1f750.akpm@linux-foundation.org> <20070602065923.GB8387@cvg> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2 Jun 2007 10:59:23 +0400 Cyrill Gorcunov wrote: > [Andrew Morton - Fri, Jun 01, 2007 at 11:54:22PM -0700] > | On Sat, 2 Jun 2007 10:34:03 +0400 Cyrill Gorcunov wrote: > | > | > | That patch is DOA, methinks. > | > | > | > > | > Andrew, what does it mean - "DOA"? Dead on arrival? > | > | yes - I dropped it. > | > > But that could lead to rejection of my code-style-conversion patch... > Should I remake them? Actually I've rebuilt those patches four times already. People keep changing stuff. > Actually Jan was right, the current state of UDF (without his patches) > could lead to lost blocks and his patch must be just fixed I think. sure.