public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	Sam Ravnborg <sam@ravnborg.org>, Dave Jones <davej@redhat.com>
Subject: Re: Conditionals for development tests and output
Date: Sat, 2 Jun 2007 16:43:48 +0200	[thread overview]
Message-ID: <20070602144348.GD5500@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0706012113200.11472@schroedinger.engr.sgi.com>

On Fri, Jun 01, 2007 at 09:17:53PM -0700, Christoph Lameter wrote:
> This introduces 
> 
> CONFIG_DEVELKERNEL
> 
> If CONFIG_DEVELKERNEL is set then this is a development kernel.
> Otherwise the kernel to be built is a a production kernel.
>...

I have two problems with your patch:

First, there will be a slub/slab specific mechanism for debug code 
controlled by a parameter in the Makefile plus the common 
CONFIG_DEBUG_KERNEL approach used by most other debug options.
We need one approach for all options.

And your approach could easily result in code paths never tested in 
-mm or -rc kernels exploding in the actual release.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2007-06-02 14:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-02  4:17 Conditionals for development tests and output Christoph Lameter
2007-06-02 14:43 ` Adrian Bunk [this message]
2007-06-02 17:48   ` Andrew Morton
2007-06-03 16:27     ` Matt Mackall
2007-06-02 19:02 ` Sam Ravnborg
2007-06-02 23:29   ` Christoph Lameter
2007-06-03  8:17     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070602144348.GD5500@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox