From: Wouter Verhelst <wouter@debian.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org,
Roman Zippel <zippel@linux-m68k.org>
Subject: Re: [patch 1/2] m68k: runtime patching infrastructure
Date: Sun, 3 Jun 2007 17:56:49 +0200 [thread overview]
Message-ID: <20070603155649.GB28228@grep.be> (raw)
In-Reply-To: <20070529173818.fd94ae81.akpm@linux-foundation.org>
On Tue, May 29, 2007 at 05:38:18PM -0700, Andrew Morton wrote:
[...]
> > +struct mod_arch_specific {
> > + struct m68k_fixup_info *fixup_start, *fixup_end;
> > +};
>
> Here we use struct m68k_fixup_info.
[...]
> > +struct m68k_fixup_info {
> > + enum m68k_fixup_type type;
> > + void *addr;
> > +};
>
> and later we define it.
>
> How come it doesn't spit warnings?
Because otherwise you couldn't create linked lists:
struct foo {
void* data;
struct foo* next;
};
At that point it hasn't been defined yet but it is being used. This is
legal, so the compiler can't create a warning for that.
Which is not to say that it's a nice coding style, but that's a
different matter.
--
Shaw's Principle:
Build a system that even a fool can use, and only a fool will
want to use it.
next prev parent reply other threads:[~2007-06-03 15:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-28 19:16 [patch 0/2] A few more m68k patches Geert Uytterhoeven
2007-05-28 19:16 ` [patch 1/2] m68k: runtime patching infrastructure Geert Uytterhoeven
2007-05-30 0:38 ` Andrew Morton
2007-05-30 5:48 ` Eric Dumazet
2007-05-30 7:06 ` Geert Uytterhoeven
2007-05-30 8:20 ` Joerg Dorchain
2007-05-30 11:19 ` Geert Uytterhoeven
2007-05-30 11:40 ` Joerg Dorchain
2007-05-30 8:23 ` Andreas Schwab
2007-05-30 18:03 ` Linus Torvalds
2007-06-03 15:56 ` Wouter Verhelst [this message]
2007-05-28 19:16 ` [patch 2/2] m68k: Discontinuous memory support Geert Uytterhoeven
2007-05-30 0:44 ` Andrew Morton
2007-05-30 0:45 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070603155649.GB28228@grep.be \
--to=wouter@debian.org \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox