public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Eric Dumazet <dada1@cosmosbay.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ulrich Drepper <drepper@redhat.com>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch 1/2] ufd v1 - unsequential O(1) fdmap core
Date: Sun, 3 Jun 2007 23:08:59 -0700	[thread overview]
Message-ID: <20070603230859.5000424d.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0706031536000.13247@alien.or.mcafeemobile.com>

On Sun, 3 Jun 2007 15:51:13 -0700 (PDT) Davide Libenzi <davidel@xmailserver.org> wrote:

> A bitmap allocator made sense because it has the property of making 
> allocations compact. Once that requirement is relaxed, it does not make 
> any sense to use it (and you have still to modify it in any case).
> I generally agree on code re-use, but that just not the right structure. 
> You can tweak it how much you like, but you're still doing a search inside 
> an N-sized bitmap. It's just the *wrong* structure.

I must say that it's not really clear to me why this fdmap thing was
created.  Exactly what problem is it solving, and what properties is it
designed to have?

Could not a (prehaps suitably modified) IDR tree have adequately provided
those properties?

I'm sure it's good stuff, but the patches were presented as if we all know
what they're for.  But I don't.  Maybe I was asleep at the time.


  reply	other threads:[~2007-06-04  6:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-02 22:59 [patch 1/2] ufd v1 - unsequential O(1) fdmap core Davide Libenzi
2007-06-03 21:19 ` Eric Dumazet
2007-06-03 22:51   ` Davide Libenzi
2007-06-04  6:08     ` Andrew Morton [this message]
2007-06-04  8:05       ` Ingo Molnar
2007-06-04  8:09         ` Ingo Molnar
2007-06-04  8:34           ` Andrew Morton
2007-06-04  8:42             ` Ingo Molnar
2007-06-04  8:47               ` Andrew Morton
2007-06-04 13:05                 ` Davide Libenzi
2007-06-04 13:30                   ` Davide Libenzi
2007-06-04 16:56                   ` Andrew Morton
2007-06-04 17:57                     ` Davide Libenzi
2007-06-04 10:28             ` Eric Dumazet
2007-06-04 12:55               ` Davide Libenzi
2007-06-04 13:25                 ` Eric Dumazet
2007-06-04 13:33                   ` Davide Libenzi
2007-06-04 13:35                   ` Davide Libenzi
2007-06-04 14:28                     ` Eric Dumazet
2007-06-04 14:53                       ` Davide Libenzi
2007-06-04 14:12                   ` Ingo Molnar
2007-06-04 14:27                     ` Eric Dumazet
2007-06-05 20:37                       ` Ingo Molnar
2007-06-05 20:50                         ` Thomas Gleixner
2007-06-05 20:57                         ` Eric Dumazet
2007-06-05 22:29                         ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070603230859.5000424d.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dada1@cosmosbay.com \
    --cc=davidel@xmailserver.org \
    --cc=drepper@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox