public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: "Joerg Roedel" <joerg.roedel@amd.com>
Cc: linux-kernel@vger.kernel.org,
	"Joachim Deguara" <joachim.deguara@amd.com>,
	"Nagendra, Bhavana" <bhavana.nagendra@amd.com>
Subject: Re: [PATCH] x86_64: remove check for CONSTANT_TSC from time.c
Date: Mon, 4 Jun 2007 20:02:40 +0200	[thread overview]
Message-ID: <200706042002.41091.ak@suse.de> (raw)
In-Reply-To: <20070604174926.GA22013@amd.com>

On Monday 04 June 2007 19:49, Joerg Roedel wrote:
> From: Joerg Roedel <joerg.roedel@amd.com>
>
> This patch removes the check for the CONSTANT_TSC cpu flag from time.c
> on the x86_64 architecture. At the time this flag is checked at boot the
> cpu init code was yet not executed and thus the check fails. At this
> point the check for VENDOR_AMD and cpu family 0x10 is sufficient.

Wrong fix. The bit just needs to be set earlier in early cpu detect. Otherwise 
there is a problem again with the next constant TSC AMD CPU.
I will do that.

-Andi

  reply	other threads:[~2007-06-04 18:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-04 17:49 [PATCH] x86_64: remove check for CONSTANT_TSC from time.c Joerg Roedel
2007-06-04 18:02 ` Andi Kleen [this message]
2007-06-04 20:41   ` Joerg Roedel
2007-06-04 22:23     ` Nagendra, Bhavana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706042002.41091.ak@suse.de \
    --to=ak@suse.de \
    --cc=bhavana.nagendra@amd.com \
    --cc=joachim.deguara@amd.com \
    --cc=joerg.roedel@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox