From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Matt Mackall <mpm@selenic.com>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org
Subject: Re: lguest rebroken in 2.6.22-rc3-mm1
Date: Mon, 4 Jun 2007 20:12:15 +0200 [thread overview]
Message-ID: <200706042012.15915.ak@suse.de> (raw)
In-Reply-To: <20070604102820.a4a0ee15.akpm@linux-foundation.org>
> >
> > Looks like this one got lost in rc3-mm1.
>
> Andi said that he fixed the zero-divide by other means?
I determined it cannot happen in my source tree. When notsc
is passed TSC CPUID is cleared and sched-clock works.
I suspect what happens is that lguest forgets to clear the TSC cpuid
bit when it disables TSC. Then the TSC frequency doesn't get computed
and sched-clock can divide by zero.That's purely a lguest bug that needs
to be fixed in lguest with a
clear_bit(X86_FEATURE_TSC, &boot_cpu_data.x86_capability)
somewhere
-Andi
next prev parent reply other threads:[~2007-06-04 18:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 22:38 lguest broken in 2.6.22-rc1-mm1 Matt Mackall
2007-05-22 23:27 ` Rusty Russell
2007-06-04 17:19 ` lguest rebroken in 2.6.22-rc3-mm1 Matt Mackall
2007-06-04 17:28 ` Andrew Morton
2007-06-04 17:46 ` Matt Mackall
2007-06-04 18:12 ` Andi Kleen [this message]
2007-06-05 2:48 ` Rusty Russell
2007-06-05 10:01 ` Andi Kleen
2007-06-05 13:11 ` [PATCH] lguest-fix-divide-error-implement-sched_clock Rusty Russell
2007-06-05 14:24 ` Andi Kleen
2007-06-05 16:07 ` Andrew Morton
2007-06-05 16:16 ` H. Peter Anvin
2007-06-05 16:37 ` Andi Kleen
2007-06-05 17:02 ` H. Peter Anvin
2007-06-05 18:43 ` H. Peter Anvin
2007-06-05 18:51 ` Andi Kleen
2007-06-05 21:15 ` H. Peter Anvin
2007-06-05 21:31 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706042012.15915.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox