From: Adrian Bunk <bunk@stusta.de>
To: Krzysztof Helt <krzysztof.h1@wp.pl>, Antonino Daplas <adaplas@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: [RFC: 2.6 patch] drivers/video/pm3fb.c: possible cleanups
Date: Tue, 5 Jun 2007 00:12:57 +0200 [thread overview]
Message-ID: <20070604221257.GD5500@stusta.de> (raw)
This patch contains the following possible cleanups:
- remove the empty pm3fb_setup() and corresponding code
- pm3fb_init() can become static
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/video/pm3fb.c | 31 +------------------------------
1 file changed, 1 insertion(+), 30 deletions(-)
--- linux-2.6.22-rc3-mm1/drivers/video/pm3fb.c.old 2007-06-04 22:49:25.000000000 +0200
+++ linux-2.6.22-rc3-mm1/drivers/video/pm3fb.c 2007-06-04 22:52:54.000000000 +0200
@@ -380,8 +380,6 @@ static void pm3fb_write_mode(struct fb_i
/*
* hardware independent functions
*/
-int pm3fb_init(void);
-
static int pm3fb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
{
u32 lpitch;
@@ -935,35 +933,8 @@ static struct pci_driver pm3fb_driver =
MODULE_DEVICE_TABLE(pci, pm3fb_id_table);
-#ifndef MODULE
- /*
- * Setup
- */
-
-/*
- * Only necessary if your driver takes special options,
- * otherwise we fall back on the generic fb_setup().
- */
-static int __init pm3fb_setup(char *options)
+static int __init pm3fb_init(void)
{
- /* Parse user speficied options (`video=pm3fb:') */
- return 0;
-}
-#endif /* MODULE */
-
-int __init pm3fb_init(void)
-{
- /*
- * For kernel boot options (in 'video=pm3fb:<options>' format)
- */
-#ifndef MODULE
- char *option = NULL;
-
- if (fb_get_options("pm3fb", &option))
- return -ENODEV;
- pm3fb_setup(option);
-#endif
-
return pci_register_driver(&pm3fb_driver);
}
next reply other threads:[~2007-06-04 22:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-04 22:12 Adrian Bunk [this message]
2007-06-05 10:45 ` [RFC: 2.6 patch] drivers/video/pm3fb.c: possible cleanups Antonino A. Daplas
2007-06-06 15:40 ` Krzysztof Helt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070604221257.GD5500@stusta.de \
--to=bunk@stusta.de \
--cc=adaplas@gmail.com \
--cc=krzysztof.h1@wp.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox