From: Andi Kleen <ak@suse.de>
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86_64: change dm_ioremap to ioremap
Date: Tue, 5 Jun 2007 12:06:51 +0200 [thread overview]
Message-ID: <200706051206.52012.ak@suse.de> (raw)
In-Reply-To: <86802c440706042321k4d83a33dpa0a09deb5fbd5a3a@mail.gmail.com>
On Tuesday 05 June 2007 08:21:23 Yinghai Lu wrote:
> [PATCH] x86_64: change dmi_ioremap to ioremap
>
> dmi_scan_machine==>dmi_present==>dmi_table==>dmi_ioremap uses
> early_ioremap in mm/init.c
> dmi_scan_machine is called after init_memory_mappings, and could use
> ioremap instead.
> also remove extra extern declaring about dmi_ioremap
init_memory_mapping is not enough; it also needs a working
page allocator. But at this point there is only bootmem.
I don't think the patch is correct.
-Andi
next prev parent reply other threads:[~2007-06-05 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 6:21 [PATCH] x86_64: change dm_ioremap to ioremap Yinghai Lu
2007-06-05 10:06 ` Andi Kleen [this message]
2007-06-06 4:14 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706051206.52012.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox