public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matt Mackall <mpm@selenic.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
	bzolnier@gmail.com
Subject: Re: [PATCH 3/6] lguest suppress IDE probing
Date: Tue, 5 Jun 2007 10:32:21 -0500	[thread overview]
Message-ID: <20070605153221.GV11115@waste.org> (raw)
In-Reply-To: <1181055483.14054.40.camel@localhost.localdomain>

On Wed, Jun 06, 2007 at 12:58:03AM +1000, Rusty Russell wrote:
> The IDE probe is the slowest part of boot: by suppressing it we cut
> boot from from 3 seconds to half a second.
> 
> AFAICT, the commandline is the easiest way to suppress the probing.

Switching to libata accomplishes the same and isn't quite as ugly. I'd
just drop this patch and put a note about it in lguest.txt, as libata
seems to be the fashionable thing to do these days.

> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> ---
>  drivers/lguest/lguest.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> ===================================================================
> --- a/drivers/lguest/lguest.c
> +++ b/drivers/lguest/lguest.c
> @@ -605,6 +605,12 @@ __init void lguest_init(void *boot)
>  	acpi_disabled = 1;
>  	acpi_ht = 0;
>  #endif
> +#ifdef CONFIG_BLK_DEV_IDE
> +	/* Saves three seconds off boot time. */
> +	strcat(boot_command_line,
> +	       " ide0=noprobe ide1=noprobe ide2=noprobe"
> +	       " ide3=noprobe ide4=noprobe ide5=noprobe");
> +#endif
>  
>  	add_preferred_console("hvc", 0, NULL);
>  
> 

-- 
Mathematics is the supreme nostalgia of our time.

  parent reply	other threads:[~2007-06-05 15:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-05 14:55 [PATCH 1/6] lguest example launcher fix Rusty Russell
2007-06-05 14:56 ` [PATCH 2/6] lguest tsc fix Rusty Russell
2007-06-05 14:58   ` [PATCH 3/6] lguest suppress IDE probing Rusty Russell
2007-06-05 15:00     ` [PATCH 4/6] lguest don't signal like crazy, use LHREQ_BREAK command Rusty Russell
2007-06-05 15:02       ` [PATCH 5/6] lguest use TSC Rusty Russell
2007-06-05 15:09         ` [PATCH 6/6] lguest use hrtimers Rusty Russell
2007-06-05 15:34       ` [PATCH 4/6] lguest don't signal like crazy, use LHREQ_BREAK command Matt Mackall
2007-06-06  0:07         ` Rusty Russell
2007-06-06  1:00           ` Matt Mackall
2007-06-05 15:32     ` Matt Mackall [this message]
2007-06-05 16:07     ` [PATCH 3/6] lguest suppress IDE probing Alan Cox
2007-06-05 16:10       ` Jeff Garzik
2007-06-05 17:09       ` James Morris
2007-06-06  1:10       ` Rusty Russell
2007-06-06 10:23         ` Alan Cox
2007-06-07  2:13           ` Rusty Russell
2007-06-07 14:45             ` Matt Mackall
2007-06-05 18:15   ` [PATCH 2/6] lguest tsc fix Andi Kleen
2007-06-06  0:25     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070605153221.GV11115@waste.org \
    --to=mpm@selenic.com \
    --cc=akpm@linux-foundation.org \
    --cc=bzolnier@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox