Re: libata & no PCI: dma_[un]map_single undefined

[Russell King <rmk+lkml@arm.linux.org.uk>]

On Tue, Jun 05, 2007 at 04:50:56PM +0100, Alan Cox wrote:
> > If you don't have DMA capabilities, does libata still need ->pad and
> > ->pad_dma set?
> 
> It shouldn't - nor the prd. You don't need to use the default
> ata_port_start in this case. I've just added ata_sff_port_start to my
> tree which figures out which to allocate for SFF devices.

I had already sorted out the PRD, but I couldn't convince myself that
the pad stuff wasn't used, so for pata_icside I had:

static int pata_icside_port_start(struct ata_port *ap)
{
        /* No PRD to alloc */
        return ata_pad_alloc(ap, ap->dev);
}

Therefore, I can just arrange for this to do nothing and just return
zero.  A similar fix for pata_platform should probably also be in order
as well.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of: