From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] UDF: coding style conversion - lindent fixups 2
Date: Tue, 5 Jun 2007 22:28:50 +0400 [thread overview]
Message-ID: <20070605182850.GD8398@cvg> (raw)
In-Reply-To: <1181067646.23941.31.camel@localhost>
[Joe Perches - Tue, Jun 05, 2007 at 11:20:46AM -0700]
| On Tue, 2007-06-05 at 22:03 +0400, Cyrill Gorcunov wrote:
| > - cpu_to_le32(epos.offset -
| > - sizeof(struct allocExtDesc));
| > - if (!UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_STRICT)
| > - || UDF_SB_UDFREV(inode->i_sb) >= 0x0201)
| > + cpu_to_le32(epos.offset -
| > + sizeof(struct allocExtDesc));
| > + if (!UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_STRICT) ||
| > + UDF_SB_UDFREV(inode->i_sb) >= 0x0201)
|
| Please do not move logical operators or tests from
| "beginning of next line" to "end of line".
|
| It's coder taste and there is no style guide consensus for this.
|
| cheers,
|
| Joe
|
Actually a such conversion were made by Lindent - not coder...
See for original truncate.c in current Linus's tree
Cyrill
prev parent reply other threads:[~2007-06-05 18:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 18:03 [PATCH] UDF: coding style conversion - lindent fixups 2 Cyrill Gorcunov
[not found] ` <1181067646.23941.31.camel@localhost>
2007-06-05 18:28 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070605182850.GD8398@cvg \
--to=gorcunov@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox