Re: [-mm patch] kernel/power/disk.c: make code static

Rafael J. Wysocki
2007-06-05T22:05:04Z

On Tuesday, 5 June 2007 23:50, Adrian Bunk wrote:
> On Wed, May 30, 2007 at 11:58:23PM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.22-rc2-mm1:
> >...
> > +swsusp-remove-code-duplication-between-diskc-and-userc.patch
> >...
> > freezer/swsusp updates
> >...
>
> This patch makes needlessly global code static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

ACK

Rafael

> ---
>
> kernel/power/disk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.22-rc3-mm1/kernel/power/disk.c.old 2007-06-05 22:12:07.000000000 +0200
> +++ linux-2.6.22-rc3-mm1/kernel/power/disk.c 2007-06-05 22:13:37.000000000 +0200
> @@ -45,7 +45,7 @@
>
> static int hibernation_mode = HIBERNATION_SHUTDOWN;
>
> -struct hibernation_ops *hibernation_ops;
> +static struct hibernation_ops *hibernation_ops;
>
> /**
> * hibernation_set_ops - set the global hibernate operations
> @@ -231,7 +231,7 @@
> * to power off or reboot.
> */
>
> -void power_down(void)
> +static void power_down(void)
> {
> switch (hibernation_mode) {
> case HIBERNATION_TEST:
>
>
>

--
"Premature optimization is the root of all evil." - Donald Knuth