Re: 2.6.22-rc4-mm1

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 6 Jun 2007 17:32:33 -0700 "Paul Menage" <menage@google.com> wrote:

> On 6/6/07, William Lee Irwin III <wli@holomorphy.com> wrote:
> >
> > (1) build for i386 with my .config
> > (2) attempt to boot in qemu's i386 system simulator
> >
> > I'm not seeing the sort of nondeterminism Andy Whitcroft is. It breaks
> > every time when I try this.
> >
> 
> Looks to be lockdep related - it's reproducible for me when I turn on
> CONFIG_LOCKDEP and the early crash goes away when I move the
> container_init_early() call to after lockdep_init().
> 

ooh, yes, lockdep_init() really does want to be called before anything
else.

So do we take it that this code hasn't been tested with lockdep?  Please
don't forget that step - lockdep finds some pretty nasty bugs sometimes.

This?

--- a/init/main.c~containersv10-basic-container-framework-fix-2
+++ a/init/main.c
@@ -503,7 +503,6 @@ asmlinkage void __init start_kernel(void
 	char * command_line;
 	extern struct kernel_param __start___param[], __stop___param[];
 
-	container_init_early();
 	smp_setup_processor_id();
 
 	/*
@@ -512,6 +511,7 @@ asmlinkage void __init start_kernel(void
 	 */
 	unwind_init();
 	lockdep_init();
+	container_init_early();
 
 	local_irq_disable();
 	early_boot_irqs_off();
_